Fix brsc and suppress warnings #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This fixes an assertion (regarding the |
draganmladjenovic
approved these changes
Jul 7, 2023
Collaborator
|
@milica-lazarevic should be created against |
farazs-github
requested changes
Jul 9, 2023
Member
farazs-github
left a comment
farazs-github
left a comment
There was a problem hiding this comment.
This PR contains a lot of duplicate changes from PR #10
Collaborator
Yes, but the PR was not merged with the |
Added isBarier flag to definition of BRSC_NM. Suppressed warnings during build: - Reordered NanoMipsJumpTableInfo constructor parameters. - Added override identifier to use useIPRA.
milica-lazarevic
force-pushed
the
jump-table-opt-fix
branch
from
c9bf9da to
dc3caf8
Compare
cme
approved these changes
Jul 14, 2023
| bool JIT); | ||
|
|
||
| bool useIPRA() const { | ||
| bool useIPRA() const override { |
There was a problem hiding this comment.
Thanks, I have kept meaning to do this for a very long time :D
farazs-github
pushed a commit
that referenced
this pull request
Mar 11, 2024
Fix brsc and suppress warnings
milica-lazarevic
pushed a commit
that referenced
this pull request
Jun 18, 2024
Fix brsc and suppress warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added isBarier flag to definition of BRSC_NM.
Suppressed warnings during build: