-
Notifications
You must be signed in to change notification settings - Fork 1
Audio alerts #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Audio alerts #5
Conversation
|
Looping in @CleezyITP to have a look at the demo! |
|
@omnikrll can we get a couple versions to test with? Could just be me, but the sound is a bit abrupt/scary. Also see @therewasaguy 's work on the console: processing/p5.js-web-editor#13 . I think we don't want to impose too many rules on users (whether or not to use semi-colons when not necessary), so we should follow Jason's standard. |
|
@CleezyITP sorry, didn't see your reply there. i'll make a few different alert styles that we can pick from, and i'll look over jason's console work (the strict imposing semicolons is just a default jslint config thing though). thinking it might be worthwhile to start wrapping this as a react component so it can integrate directly with jason's console component. |
|
Hi Karl - looks like Cassie has linting in place. |
|
@MathuraMG oh... so it looks like y'all are using the same concept but playing back audio samples instead of synthesizing the tones in web audio... would have been nice to know y'all were gonna do that. if you're not going to use my code, what & how should i contribute? i could make some more alert sounds, or something? |
It beeps at you when there's errors in your code!
Demo here: https://omnikrll.github.io/CodeMirror/