Skip to content

Conversation

@omnikrll
Copy link
Collaborator

It beeps at you when there's errors in your code!

Demo here: https://omnikrll.github.io/CodeMirror/

@MathuraMG
Copy link
Owner

Looping in @CleezyITP to have a look at the demo!

@CleezyITP
Copy link

@omnikrll can we get a couple versions to test with? Could just be me, but the sound is a bit abrupt/scary. Also see @therewasaguy 's work on the console: processing/p5.js-web-editor#13 . I think we don't want to impose too many rules on users (whether or not to use semi-colons when not necessary), so we should follow Jason's standard.

@omnikrll
Copy link
Collaborator Author

@CleezyITP sorry, didn't see your reply there. i'll make a few different alert styles that we can pick from, and i'll look over jason's console work (the strict imposing semicolons is just a default jslint config thing though). thinking it might be worthwhile to start wrapping this as a react component so it can integrate directly with jason's console component.

@MathuraMG
Copy link
Owner

Hi Karl - looks like Cassie has linting in place.
I'm so sorry, I forgot about this PR over the last week or two - we worked on making the linting accessible (also using audio beeps), here is the PR. We are about to merge this in. Would it make more sense to resume with your work on the alerting once the PR is in?
@CleezyITP Does this sound ok?

@omnikrll
Copy link
Collaborator Author

@MathuraMG oh... so it looks like y'all are using the same concept but playing back audio samples instead of synthesizing the tones in web audio... would have been nice to know y'all were gonna do that.

if you're not going to use my code, what & how should i contribute? i could make some more alert sounds, or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants