Console #13
Merged
Console #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
therewasaguy
commented
Jul 18, 2016
therewasaguy
commented
- a basic, non-interactive Console component
- previewFrame injects a script into the iframe that uses postMessage to send errors and console messages. It catches referenceErrors with window.onError. It doesn't catch syntax errors (seems like these are already caught with linting?)
| } | ||
|
|
||
| // assign styles to different types of console messages | ||
| .log { |
Member
There was a problem hiding this comment.
for this project I'm using BEM naming convention, so these class names should be .preview-console__log, .preview-console__warn, and .preview-console__error. Let's also make these colors the same as the linting error colors, #ffbe05 and #ff5f52. all of the other styling is fine for now.
Member
Author
There was a problem hiding this comment.
sounds good! I'll fix that
Member
Author
|
updated with BEM style |
raclim
added a commit
that referenced
this pull request
Oct 3, 2025
…attempt pr05 Typescript Migration #13: Migrate the User Model (& API Key schema)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.