Skip to content

Conversation

Copy link

Copilot AI commented Dec 31, 2025

Addresses unused variable warnings from PR #103 review thread.

Changes

  • GithubProviderClient.ts:258: Added ensureOk() call to validate HTTP status when listing query versions, consistent with other methods in the class
  • fix-esm-imports.mjs:39: Removed unused candidate variable in import rewrite function
// Before
const { status, json } = await this.request<GithubCommit[]>(...);
const commits = Array.isArray(json) ? json : [];

// After
const { status, json } = await this.request<GithubCommit[]>(...);
this.ensureOk(status, "Failed to list query versions.");
const commits = Array.isArray(json) ? json : [];

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>
Copilot AI changed the title [WIP] Add comprehensive query management feature to YASGUI fix: remove unused variables flagged in code review Dec 31, 2025
Copilot AI requested a review from MathiasVDA December 31, 2025 22:57
@MathiasVDA MathiasVDA marked this pull request as ready for review December 31, 2025 23:01
@MathiasVDA MathiasVDA merged commit b680a65 into 001-query-management Dec 31, 2025
@MathiasVDA MathiasVDA deleted the copilot/sub-pr-103-again branch December 31, 2025 23:01
MathiasVDA added a commit that referenced this pull request Dec 31, 2025
…ng a sparql endpoint or git repo as backend

* docs: add YASGUI spec.kit constitution v1.0.0

* docs: add specification for query management feature

* docs: add plan for query management

* docs: further work on specs

* chore: improve ignore files

* feat: add implementation of query management feature

* chore: add tests for query management feature

* docs: describe new feature in user guide

* fix: git renaming and deleting actions causing 409 merge conflicts

* docs: add a recomendation for the backend

* fix: several issues

* feat: add documentation if now workspaces have been defined

* fix: remove unused variables flagged in code review (#105)

* Initial plan

* fix: remove unused variables from code review

Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants