Skip to content

fix: remove unused variables flagged in code review #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVDA merged 2 commits into from
Dec 31, 2025
Merged

fix: remove unused variables flagged in code review #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3566f7f
Initial plan
Copilot Dec 31, 2025
037ded7
fix: remove unused variables from code review
Copilot Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/yasgui/src/queryManagement/backends/GithubProviderClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,8 @@ export class GithubProviderClient extends BaseGitProviderClient {
`/repos/${encodeURIComponent(owner)}/${encodeURIComponent(repo)}/commits?${qs.toString()}`,
);

this.ensureOk(status, "Failed to list query versions.");

const commits = Array.isArray(json) ? json : [];
return commits
.map((c) => {
Expand Down
1 change: 0 additions & 1 deletion test/fix-esm-imports.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ function rewriteSource(source, filePath) {
/(\bfrom\s+["'])(\.\.?\/.+?)(["'])/g,
(match, prefix, spec, suffix) => {
if (!shouldRewrite(spec)) return match;
const candidate = path.join(path.dirname(filePath), spec + ".js");
return prefix + spec + ".js" + suffix;
},
);
Expand Down