-
Notifications
You must be signed in to change notification settings - Fork 2
001 query management #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
001 query management #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements a comprehensive query management feature that adds long-term, versioned query storage capabilities to YASGUI through configurable workspaces. The implementation supports both Git-based and SPARQL endpoint-based storage backends, allowing users to manage queries beyond browser storage limitations.
Key Changes
- Backend Infrastructure: Implements a pluggable workspace backend system with support for multiple Git providers (GitHub, GitLab, Bitbucket, Gitea) and SPARQL endpoints
- UI Components: Adds Query Browser, workspace settings management, and save dialogs with proper accessibility support
- Unit Testing: Introduces Node-based unit tests covering backend contracts, versioning rules, error handling, and browser filtering
Reviewed changes
Copilot reviewed 93 out of 94 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig-test.json | Updated to include unit test files under test/unit/ directory |
| test/unit/*.ts | Eight new unit test files covering backend functionality, versioning, validation, and filtering |
| test/fix-esm-imports.mjs | ESM import fixer script for compiled test output |
| specs/001-query-management/*.md | Comprehensive specification documents including plan, spec, research, quickstart, and tasks |
| packages/yasgui/src/queryManagement/*.ts | Core query management modules: types, validation, save/open logic, filtering, and text hashing |
| packages/yasgui/src/queryManagement/backends/*.ts | Backend implementations for Git providers and SPARQL endpoints, plus error handling |
| packages/yasgui/src/queryManagement/*.scss | Styling for QueryBrowser and SaveManagedQueryModal components |
| packages/yasgui/src/index.ts | Integration of QueryBrowser into main Yasgui class |
| packages/yasgui/src/Tab*.ts | Tab-related changes for managed query support and workspace settings |
| packages/yasgui/src/themes.scss | New theme variables for managed query styling |
| packages/yasqe/src/scss/buttons.scss | Button styling for save managed query action |
| .prettierignore | Additional ignore patterns for build artifacts |
|
@MathiasVDA I've opened a new pull request, #104, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@MathiasVDA I've opened a new pull request, #105, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * fix: remove unused variables from code review Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>
Fixes #35