Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: distinguish errors #980

Closed
wants to merge 18 commits into from
Closed

Fix: distinguish errors #980

wants to merge 18 commits into from

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Jan 10, 2023

Description

Added the improved error handling as in the latest commits of Manta-Network/manta-rs#294.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@github-actions
Copy link

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@SupremoUGH SupremoUGH added L-fixed Log: Issues and PRs related to bug fixes A-manta-pay Area: Issues and PRs related to the MantaPay Pallet A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime labels Jan 10, 2023
SupremoUGH and others added 17 commits January 10, 2023 20:01
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
* fix badge

Signed-off-by: Adam Reif <Garandor@manta.network>

* remove mention of milestone from PR template

Signed-off-by: Adam Reif <Garandor@manta.network>

* connect issue uses zenhub

Signed-off-by: Adam Reif <Garandor@manta.network>

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
- Parachain ID 2100
- production keys
- move `from_seed_unchecked` from primitives into runtime, Manta RT has 2 keys, Calamari/Dolphin have AuraId as extra key
- remove service_aura since manta RT no longer uses it

Signed-off-by: Adam Reif <Garandor@manta.network>

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
* Split unit test and benchark

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use all threads for unit tests

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use dev branch for CI test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix yml

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Get rid of -dev tests

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix dependencies

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use dev branch for test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use dev branch for test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Check

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Check

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Revert for pr

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
* Bump crate version

Signed-off-by: Dengjianping <djptux@gmail.com>

* Bump spev version

Signed-off-by: Dengjianping <djptux@gmail.com>

* Update weights for calamari and dolphin

Signed-off-by: Dengjianping <djptux@gmail.com>

* run txver update check against v343

Signed-off-by: Adam Reif <Garandor@manta.network>

* Add updated changelog

Signed-off-by: Adam Reif <Garandor@manta.network>

* Update polkadot binary

Signed-off-by: Dengjianping <djptux@gmail.com>

* add 956 to changelog

Signed-off-by: Adam Reif <Garandor@manta.network>

Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Adam Reif <Garandor@manta.network>
Co-authored-by: Adam Reif <Garandor@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
…odolist instead of separate sections (#962)

Signed-off-by: SupremoUGH <francisco@manta.network>
* slot skip cause block2 stuck

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>

* slot skip cause block2 stuck

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>

* calamari works by only one collator

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>

* add dolphin localdev

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>

* add instant finalize

Signed-off-by: Charles Ferrell <charlie@manta.network>

* format

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>

* update dev name

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>

* build dev consensus

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Co-authored-by: Charles Ferrell <charlie@manta.network>
Co-authored-by: Adam Reif <garandor@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
@SupremoUGH SupremoUGH closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants