Skip to content

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Dec 28, 2022

Description

relates to OR closes: #926


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

@Garandor Garandor force-pushed the garandor/manta-genesis branch from 6ab00cc to 082a605 Compare December 28, 2022 18:55
@Garandor Garandor self-assigned this Dec 28, 2022
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime L-added Log: Issues and PRs related to addition labels Dec 28, 2022
@Garandor Garandor marked this pull request as ready for review December 29, 2022 00:14
@Garandor Garandor requested review from ghzlatarev, Dengjianping and ferrell-code and removed request for ghzlatarev December 29, 2022 00:14
@Garandor Garandor force-pushed the garandor/manta-genesis branch from f15aaf6 to 0617bc2 Compare December 29, 2022 05:13
@Garandor Garandor mentioned this pull request Dec 29, 2022
6 tasks
flame4
flame4 previously approved these changes Dec 29, 2022
- Parachain ID 2100
- production keys
- move `from_seed_unchecked` from primitives into runtime, Manta RT has 2 keys, Calamari/Dolphin have AuraId as extra key
- remove service_aura since manta RT no longer uses it

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor mentioned this pull request Dec 29, 2022
1 task
@Garandor Garandor requested a review from flame4 December 29, 2022 17:05
Copy link
Contributor

@grenade grenade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all verified (c1 - c5, node, collator, nimbus, vrf).

@Garandor Garandor merged commit 7ec09a2 into manta Dec 30, 2022
@Garandor Garandor deleted the garandor/manta-genesis branch December 30, 2022 15:52
SupremoUGH pushed a commit that referenced this pull request Jan 10, 2023
- Parachain ID 2100
- production keys
- move `from_seed_unchecked` from primitives into runtime, Manta RT has 2 keys, Calamari/Dolphin have AuraId as extra key
- remove service_aura since manta RT no longer uses it

Signed-off-by: Adam Reif <Garandor@manta.network>

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Manta Parachain Genesis
6 participants