fix: distinguish between panic-errors and possible-fix-errors #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
ghzlatarev
reviewed
Dec 22, 2022
ferrell-code
requested review from
SupremoUGH,
stechu,
Garandor and
ghzlatarev
ferrell-code
previously approved these changes
Dec 27, 2022
ghzlatarev
previously approved these changes
Dec 27, 2022
There was a problem hiding this comment.
@ferrell-code not sure if the CI is expected to fail though
|
Yeah not sure either @ghzlatarev , but it seems to be an existing problem that was not introduced in this PR. |
Signed-off-by: Charles Ferrell <charlie@manta.network>
ferrell-code
dismissed stale reviews from ghzlatarev and themself
via
0f4479e
ferrell-code
added
changelog:fixed
ferrell-code
previously approved these changes
Dec 27, 2022
ferrell-code
previously approved these changes
Dec 27, 2022
Garandor
reviewed
Dec 28, 2022
Signed-off-by: Charles Ferrell <charlie@manta.network>
…work/manta-rs into fix/distinguish-errors
4 tasks
added 2 commits
January 9, 2023 13:44
ghzlatarev
previously approved these changes
Jan 9, 2023
ferrell-code
previously approved these changes
Jan 9, 2023
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
requested review from
SupremoUGH,
Garandor,
ghzlatarev and
ferrell-code
and removed request for
stechu and
SupremoUGH
ghzlatarev
approved these changes
Jan 10, 2023
ferrell-code
approved these changes
Jan 10, 2023
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon H. Gomes bhgomes@pm.me
To ensure that panics don't occur in the runtime we have to distinguish between the errors that are non-recoverable (i.e. panics in Rust) and recoverable errors.
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.mdand added the appropriatechangeloglabel to the PR.Files changedin the GitHub PR explorer.CONTRIBUTING.md.