Skip to content

Conversation

@chopan050
Copy link
Contributor

As mentioned in a comment thread to PR #4003, there are multiple definitions of init_points which look like

init_points = generate_points

This caused the bug which was fixed in #4003. The solution there was to properly define init_points as

def init_points(self) -> None:
    self.generate_points()

This PR fixes the rest of such definitions so that init_points is properly defined as stated above in every class which defines it.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@chopan050 chopan050 added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label Jul 30, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Jul 30, 2025
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Aug 9, 2025
@behackl behackl merged commit b3df1cf into ManimCommunity:main Aug 9, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants