Skip to content

Properly define init_points methods for use in OpenGL instead of defining init_points = generate_points #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behackl merged 1 commit into from
Aug 9, 2025
+13 −7
Merged

Properly define init_points methods for use in OpenGL instead of defining init_points = generate_points #4360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions manim/mobject/geometry/arc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,8 @@ def generate_points(self) -> None:
self.append_points(outer_arc.points)
self.add_line_to(inner_arc.points[0])

init_points = generate_points
def init_points(self) -> None:
self.generate_points()


class Sector(AnnularSector):
Expand Down Expand Up @@ -990,7 +991,8 @@ def generate_points(self) -> None:
self.append_points(inner_circle.points)
self.shift(self.arc_center)

init_points = generate_points
def init_points(self) -> None:
self.generate_points()


class CubicBezier(VMobject, metaclass=ConvertToOpenGL):
Expand Down
3 changes: 2 additions & 1 deletion manim/mobject/geometry/line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ def set_points_by_ends(

self._account_for_buff(buff)

init_points = generate_points
def init_points(self) -> None:
self.generate_points()

def _account_for_buff(self, buff: float) -> None:
if buff <= 0:
Expand Down
6 changes: 4 additions & 2 deletions manim/mobject/graphing/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ def generate_points(self) -> Self:
self.make_smooth()
return self

init_points = generate_points
def init_points(self) -> None:
self.generate_points()


class FunctionGraph(ParametricFunction):
Expand Down Expand Up @@ -317,4 +318,5 @@ def generate_points(self):
self.make_smooth()
return self

init_points = generate_points
def init_points(self) -> None:
self.generate_points()
5 changes: 3 additions & 2 deletions manim/mobject/svg/svg_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ def __init__(

super().__init__(**kwargs)

def init_points(self) -> None:
def generate_points(self) -> None:
# TODO: cache mobject in a re-importable way

self.handle_commands()
Expand All @@ -509,7 +509,8 @@ def init_points(self) -> None:
# Get rid of any null curves
self.set_points(self.get_points_without_null_curves())

generate_points = init_points
def init_points(self) -> None:
self.generate_points()

def handle_commands(self) -> None:
all_points: list[np.ndarray] = []
Expand Down