Skip to content

Conversation

@ra1u
Copy link
Contributor

@ra1u ra1u commented Nov 9, 2024

Fixes Prism, that shows cube of size 2.

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for your contribution!

I have a slightly different suggestion for a more sustainable fix that takes care of the situation for all subclasses of Cube. Please take a look!

@behackl behackl added the enhancement Additions and improvements in general label Nov 24, 2024
@JasonGrace2282
Copy link
Member

Hey, I'm a little bit confused about what problem this fixes. Is there a minimal reproducible example of the problem?

@ra1u
Copy link
Contributor Author

ra1u commented Dec 7, 2024

This bug can be observed when renderer is opengl

manim render --renderer opengl prism_bug.py

prism_bug.py:

from manim import *

class PrismBug(Scene):
    def construct(self):
        self.add(Prism(dimensions=[1,2,3]))

output:

Failed:
PrismBug_ManimCE_v0 18 1_bug

Expected (after patch):
PrismBug_ManimCE_v0 18 1_ok

@chopan050 chopan050 changed the title fix Prism rendering Fix Prism rendering with wrong dimensions in OpenGL Jul 24, 2025
@chopan050 chopan050 added opengl Concerning the OpenGL renderer. pr:bugfix Bug fix for use in PRs solving a specific issue:bug labels Jul 24, 2025
@chopan050 chopan050 enabled auto-merge (squash) July 24, 2025 20:12
@chopan050 chopan050 changed the title Fix Prism rendering with wrong dimensions in OpenGL Fix Prism incorrectly rendering with dimensions=[2, 2, 2] in OpenGL Jul 24, 2025
@chopan050 chopan050 merged commit 2f02eb9 into ManimCommunity:main Jul 24, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Additions and improvements in general opengl Concerning the OpenGL renderer. pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants