Skip to content

Conversation

@skateman
Copy link
Member

@skateman skateman commented Feb 15, 2021

As now we're in the Carbon world and this form has arrays of entities (DNS servers) displayed in a textarea, we can leverage the properly implemented FieldArray component:
Screenshot from 2021-02-16 08-24-51

Other than that, the form does the same as the cloud volumes or the provider forms, i.e. loads a schema from the API using an OPTIONS request.

Resolves #6861
Depends on #7635 ManageIQ/manageiq-api#1012

Blocked by missing API endpoints ManageIQ/manageiq-api#1013

@skateman skateman changed the title [WIP] Convert the subnet form to DDF Convert the subnet form to DDF Feb 18, 2021
@miq-bot miq-bot removed the wip label Feb 18, 2021
@miq-bot
Copy link
Member

miq-bot commented Feb 18, 2021

Checked commit skateman@5caa641 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
6 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@miq-bot
Copy link
Member

miq-bot commented Mar 29, 2021

This pull request is not mergeable. Please rebase and repush.

@kavyanekkalapu
Copy link
Member

cc @DavidResende0

@kavyanekkalapu
Copy link
Member

this is done in #7734, closing it.

@Fryguy Fryguy closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form conversion: Networks/Subnets Add

5 participants