Form conversion: Networks/Subnets Add

[himdel]

Convert form to use DDF/React and API - parent issue #6825

Location: Networks/Subnets
Form: Add

current type: Angular
API state:
Need info

PM Input: 2 - Medium
Comments:
Ems common

imported status: NOT ASSIGNED

• Backend part with the supports mixin Expose ems supports_cloud_subnet_create as an API queryable attribute manageiq#21050
• API endpoint for CRUD Missing CRUD for cloud subnets manageiq-api#1013 (Add endpoint for cloud subnets manageiq-api#1025)
• API support for the OPTIONS request Expose CloudSubnet create/edit form via OPTIONS manageiq-api#1012
• OpenStack schema Implemented DDF for cloud subnets and added support mixin call manageiq-providers-openstack#690
• IBM schema Implemented DDF for cloud subnets and added support mixin call manageiq-providers-ibm_cloud#140
• Nuage schema Implemented DDF for cloud subnets and added support mixin call manageiq-providers-nuage#241
• UI Convert the subnet form to DDF #7734

[skateman]

@agrare how much is this form tied to a single provider? Trying to determine how much is this analogous with the Cloud Network form and decide if we need an API-provided schema or just a conditional single field based on a supports call.

[jaywcarman]

just a conditional single field based on a supports call.

There are actually quite a few differences between the existing form and the IbmCloud::PowerVirtualServers API parameters - we ignore some fields and are only able to support our API's public or private network type (not both). #7383 is intended to be the absolute minimum UI change required in order to get some initial functionality.

[skateman]

@jaywcarman thanks, after we finalized the schemas in #7334, we can specify the schema differences in this case as well.

[skateman]

Blocked by ManageIQ/manageiq-api#918

[skateman]

I'd need some definitions for each provider's form, how it should look like & behave, what should be required, etc. cc @agrare

[jaywcarman]

@skateman I'm searching around and I think only the OpenStack provider supports network create, and OpenStack + Nuage providers supports subnet create.

I'll start putting together schemas for OpenStack and IBM Cloud PowerVS. I don't mind also doing an initial draft for Nuage - but will probably need some help from @agrare.

[jaywcarman]

Here's a rough draft of OpenStack network create:

# ManageIQ::Providers::Openstack::NetworkManager::CloudNetwork
[
  # TODO: "Network Provider" selection
  ## Placement
  {
    :component => 'select',
    :name      => 'cloud_tenant',
    :id        => 'cloud_tenant',
    :label     => _('Cloud Tenant'),
    # TODO: Get list of tenents for selected network manager
    :options   => ems.cloud_volume_types.map do |cvt|
      {
        :label => cvt.description,
        :value => cvt.name,
      }
    end,
  },
  ## Network Provider Information
  {
    :component => 'select',
    :name      => 'provider_network_type',
    :id        => 'provider_network_type',
    :label     => _('Provider Network Type'),
    # TODO: Get list of network types for selected network manager/placement
    :options   => ems.cloud_volume_types.map do |cvt|
      {
        :label => cvt.description,
        :value => cvt.name,
      }
    end,
  },
  # Network Information
  {
    :component  => 'text-field',
    :id         => 'network_name',
    :name       => 'network_name',
    :label      => _('Network Name'),
    :isRequired => true,
    :validate   => [{:type => "required"}]
  },
  {
    :component => 'switch',
    :id        => 'external_router',
    :name      => 'external_router',
    :label     => _('External Router'),
  },
  {
    :component => 'switch',
    :id        => 'administrative_state',
    :name      => 'administrative_state',
    :label     => _('Administrative State'),
  },
  {
    :component => 'switch',
    :id        => 'shared',
    :name      => 'shared',
    :label     => _('Shared'),
    :onText    => 'Up',
    :offText   => 'Down',
  },
]

[jaywcarman]

Here's rough drafts of subnet create for OpenStack, IBM Cloud PowerVS, and nuage:

::CloudSubnet common:

[
  {
    :component => 'text-field',
    :id        => 'subnet_name',
    :name      => 'subnet_name',
    :label     => _('Subnet Name'),
  },
  {
    :component => 'text-field',
    :id        => 'subnet_cidr',
    :name      => 'subnet_cidr',
    :label     => _('Subnet CIDR'),
    :isRequired => true,
    :validate   => [{:type => 'required'}]
  },
  {
    :component => 'text-area',
    :id        => 'dns_servers',
    :name      => 'dns_servers',
    :label     => _('DNS Servers'),
  },
]

ManageIQ::Providers::IbmCloud::PowerVirtualServers::NetworkManager::CloudSubnet

[
  {
    :component => 'select',
    :name      => 'type',
    :id        => 'type',
    :label     => _('Type'),
    :options   => [
      {
        :label => 'vlan',
        :value => 'vlan',
      },
      {
        :label => 'pub-vlan',
        :value => 'pub-vlan',
      }
    ]
  },
  # TODO: Validate starting/Ending IP addresses must both be set or both be unset
  #       Use 'IP Address Ranges' subform?
  {
    :component => 'text-field',
    :id        => 'starting_ip_address',
    :name      => 'starting_ip_address',
    :label     => _('Starting IP Address'),
  },
  {
    :component => 'text-field',
    :id        => 'ending_ip_address',
    :name      => 'ending_ip_address',
    :label     => _('Ending IP Address'),
  },
  {
    :component => 'switch',
    :id        => 'jumbo',
    :name      => 'jumbo',
    :label     => _('MTU Jumbo Network'),
    :onText    => 'Enabled',
    :offText   => 'Disabled',
  },
]

ManageIQ::Providers::Openstack::NetworkManager::CloudSubnet

[
  # Network Management Provider
  # TODO:  "Network Management Provider"
  {
    :component => 'select',
    :name      => 'cloud_tenant_placement',
    :id        => 'cloud_tenant_placement',
    :label     => _('Cloud Tenant Placement'),
    # TODO: Get list of tenents for selected network manager
    :options   => ems.tenants.map do |cvt|
      {
        :label => cvt.description,
        :value => cvt.name,
      }
    end,
  },
  # Cloud Subnet details
  {
    :component => 'select',
    :name      => 'network',
    :id        => 'network',
    :label     => _('Network'),
    # TODO: Get list of networks in selected network manager
    :options   => ems.networks.map do |cvt|
      {
        :label => cvt.description,
        :value => cvt.name,
      }
    end,
    :isRequired => true,
    :validate   => [{:type => 'required'}]
  },
  {
    :component => 'text-field',
    :id        => 'gateway',
    :name      => 'gateway',
    :label     => _('Gateway'),
  },
  {
    :component => 'switch',
    :id        => 'dhcp',
    :name      => 'dhcp',
    :label     => _('DHCP'),
    :onText    => 'Enabled',
    :offText   => 'Disabled',
  },
  {
    :component => 'select',
    :name      => 'ip_version',
    :id        => 'ip_version',
    :label     => _('IP Version'),
    :options   => [
      {
        :label => 'ipv4',
        :value => 'ipv4',
      },
      {
        :label => 'ipv6',
        :value => 'ipv6',
      }
    ]
  },
  {
    :component => 'text-area',
    :id        => 'allocation_pools',
    :name      => 'allocation_pools',
    :label     => _('Allocation Pools'),
  },
  {
    :component => 'text-area',
    :id        => 'host_routes',
    :name      => 'host_routes',
    :label     => _('Host Routes'),
  },
]

ManageIQ::Providers::Nuage::NetworkManager::CloudSubnet

[
  {
    :component => 'select',
    :name      => 'network',
    :id        => 'network',
    :label     => _('Network'),
    # TODO: Get list of networks in selected network manager
    :options   => ems.networks.map do |cvt|
      {
        :label => cvt.description,
        :value => cvt.name,
      }
    end,
    :isRequired => true,
    :validate   => [{:type => 'required'}]
  },
  {
    :component => 'text-field',
    :id        => 'gateway',
    :name      => 'gateway',
    :label     => _('Gateway'),
  },
]