Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccsh no Read Rights - Change fileMode to 755 (binary) in startScript task #3607

Merged
merged 1 commit into from
May 2, 2024

Conversation

phanlezz
Copy link
Collaborator

@phanlezz phanlezz commented May 2, 2024

ccsh no Read Rights - Change fileMode to 755 (binary) in startScript task

Closes: #3603

Change fileMode property in Gradle build file to the binary representation of 7 5 5.
The number 755 was previously interpreted as a random assortment of read and write rights, that didn't make any sense.

We can remove the addition of read rights in our golden_test.sh. This will be done in #3571 to avoid unnecessary merge conflicts.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phanlezz phanlezz merged commit 5787f0a into main May 2, 2024
7 checks passed
@phanlezz phanlezz deleted the tech/3603/ccsh-no-read-rights branch May 2, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech: ccsh can't be executed on Unix systems (MacOS/Ubuntu) due to missing read rights
2 participants