-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitLogParser
in docker container
#3571
Conversation
It might not be possible to test our Dockerfile with a custom user: |
b73022e
to
04ee62e
Compare
I'm not sure why the e2e tests failed, now that the Docker Tests ran through 😆.
For me, this means, that we can't really just use Some ideas: ARGWe could use an
EntrypointWith an entrypoint script, we might have different options to deal with this problem. Changing the I suggest we try to use the ARG approach, as it keeps the test run and the regular usage close together. |
ece067b
to
220fa56
Compare
Sonar down? 👀 |
625c849
to
171b40f
Compare
Quality Gate passed for 'CodeCharta Visualization'Issues Measures |
Quality Gate passed for 'CodeCharta Analysis'Issues Measures |
Fix
GitLogParser
in docker containerFix syntax in
Dockerfile
so that sonar-scanner can be downloaded correctlychange tokei download to static link (not latest anymore)
Add a non-root user as default to docker image
Is it necessary to declare the user in the compose file?
Add an exit code validation, to verify if git exited correctly.
Closes: #3308
Closes: #3385
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Screenshots or gifs