Fix GitLogParser in docker container

[phanlezz]

Fix GitLogParser in docker container

• Fix syntax in Dockerfile so that sonar-scanner can be downloaded correctly

• change tokei download to static link (not latest anymore)

• Add a non-root user as default to docker image

• Is it necessary to declare the user in the compose file?

• Add an exit code validation, to verify if git exited correctly.

Closes: #3308
Closes: #3385

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

• Changes have been manually tested
• • Check code-maat
• • Check tokei
• • Check sonar-scanner (callable, but requires running sonar qube instance at localhost:9000)
• • Check gitlogparser
• All TODOs related to this PR have been closed
• There are automated tests for newly written code and bug fixes
• All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
• Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
• CHANGELOG.md has been updated

Screenshots or gifs

[phanlezz]

It might not be possible to test our Dockerfile with a custom user:
https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#user

[phanlezz]

I'm not sure why the e2e tests failed, now that the Docker Tests ran through 😆.
Problem is that the current setup is not really applicable:

• I changed the user id (uid) inside the docker container to 1001, which is the uid of the GitHub runner via the Dockerfile
• Now the owner uid of the repository files matches the uid inside the container and git can run (without dubious ownership issues)
• BUT: If now executed locally on e.g. Ubuntu with a native user 1000, git doesn't work anymore (because now the repository file owner is different to the docker user uid:1000 != uid:1001)

For me, this means, that we can't really just use uid:1000 as proposed in the original issue, because a regular user of the docker might have a different uid.

Some ideas:

ARG

We could use an ARG in the analysis/Dockerfile where we default a value of 1000 and inject a value of 1001 for GitHub.
This does not fix the issue with regular users, which have uids different to 1000.

We could accept this, and the user would have to adept in this special case. There might also be a possibility of a dynamic uid on container creation which copyies the host uid.

Entrypoint

With an entrypoint script, we might have different options to deal with this problem. Changing the uid, using git config to declare the folders as safe, or changing ownership of the files.

I suggest we try to use the ARG approach, as it keeps the test run and the regular usage close together.

[phanlezz]

Sonar down? 👀

[sonarcloud]

Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud