Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gradle build files #3025 #3570

Merged
merged 13 commits into from
Apr 25, 2024

Conversation

fritschldwg
Copy link
Contributor

@fritschldwg fritschldwg commented Apr 22, 2024

Refactor gradle build files #3025

⚠️ After checking out this branch in IntelliJ go to File -> Invalidate caches -> Tick all boxes -> Invalidate and restart

Closes: #3025

Description

Completed

  • ✅ Upgrade ktlint to v12.1.0
  • ✅ Upgrade gradle to v8.7
  • ✅ Upgrade kotlin-logging to v6.0.9
  • ✅ Refactor logging to use a singleton logger
  • ✅ Migrate gradle scripts to kotlin
  • ✅ Remove unused gradle tasks
  • ✅ Remove (some) unused dependencies

Open

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@fritschldwg fritschldwg force-pushed the tech/3025/refactor-gradle-build-files branch 5 times, most recently from e1bbeb5 to 39aa514 Compare April 23, 2024 12:25
@fritschldwg fritschldwg marked this pull request as ready for review April 23, 2024 12:38
@fritschldwg fritschldwg force-pushed the tech/3025/refactor-gradle-build-files branch from 39aa514 to b739527 Compare April 24, 2024 14:33
Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fritschldwg fritschldwg force-pushed the tech/3025/refactor-gradle-build-files branch from ab13a93 to 290c773 Compare April 25, 2024 10:02
@fritschldwg fritschldwg force-pushed the tech/3025/refactor-gradle-build-files branch from 290c773 to 6f4ed87 Compare April 25, 2024 12:57
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 25, 2024

@fritschldwg fritschldwg merged commit a59308f into main Apr 25, 2024
7 checks passed
@fritschldwg fritschldwg deleted the tech/3025/refactor-gradle-build-files branch April 25, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor build.gradle so that there are fewer tasks
2 participants