Skip to content

Conversation

@taneliang
Copy link
Member

@taneliang taneliang commented Aug 3, 2020

Stack PR by STACK ATTACK:

Summary

Resolves #44.

Intended to highlight all related React events. However, it looks like
separate promises can have the same wakeable ID, which is a bit strange.

TODO

  • Ensure that we are correctly understanding wakeable IDs, i.e. that
    a unique resource/promise is a unique wakeable.
  • Check if unstable_createResource caches promises.

Test Plan

  • yarn lint
  • yarn flow: no errors in changed code
  • yarn start

image

@vercel
Copy link

vercel bot commented Aug 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/qxzqo7mwz
✅ Preview: https://scheduling-profiler-prototype-git-sttack-pariatur-dolorem-illum.mlh-fellowship.vercel.app

@taneliang taneliang force-pushed the sttack-et-quasi-et branch from c6ddb0c to ac9c122 Compare August 4, 2020 05:18
Base automatically changed from sttack-et-quasi-et to master August 4, 2020 05:20
Summary
---

Resolves #44.

Intended to highlight all related React events. However, it looks like
separate promises can have the same wakeable ID, which is a bit strange.

TODO
---

* Ensure that we are correctly understanding wakeable IDs, i.e. that
  a unique resource/promise is a unique wakeable.
* Check if `unstable_createResource` caches promises.

Test Plan
---

* `yarn lint`
* `yarn flow`: no errors in changed code
@taneliang
Copy link
Member Author

Rebased on master.

We may want to use an intermediate highlight color for the related highlights in the future, so that it doesn't look like a bug in our highlighting logic

@taneliang taneliang merged commit 0660603 into master Aug 4, 2020
@taneliang taneliang deleted the sttack-pariatur-dolorem-illum branch August 4, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight all suspense events related to a wakeable when one is highlighted

2 participants