[Resize content][1/n] Break horizontal scrolling area into final-ish hierarchy #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hierarchy
Summary
---
This PR begins a PR stack that implements the resize of the lanes area.
In this PR, the view hierarchy is overhauled to more closely resemble
the final one. This is the new view hierarchy:
- View (vertically stacked layout) (root view)
- HorizontalPanAndZoomView
- View (vertically stacked layout)
- TimeAxisMarkersView
- ReactEventsView
- View (vertically stacked layout) (to be replaced with
ResizableVerticalSplitView)
- HorizontalPanAndZoomView
- VerticalScrollView
- ReactMeasuresView
- HorizontalPanAndZoomView
- VerticalScrollView
- FlamechartView
This PR must be landed with the PRs stacked above it in order not to
break master.
Test Plan
---
* `yarn lint`
* `yarn flow`: no errors in changed code
* `yarn test`
Known issues
---
* There are now 3 independent horizontal pan/zoom areas. This is
intentional; it'll be fixed in a future PR in this stack.
* Flamechart no longer scrolls vertically. This will be fixed in a
future PR in this stack.
This was referenced Aug 3, 2020
kartikcho
approved these changes
Aug 3, 2020
| layeredLayout, | ||
| zeroPoint, | ||
| verticallyStackedLayout, | ||
| zeroPoint, |
Member
There was a problem hiding this comment.
Any specific reason for the reorder?
Member
Author
There was a problem hiding this comment.
Nope, just sorting alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack PR by STACK ATTACK:
Summary
This PR begins a PR stack that implements the resize of the lanes area.
In this PR, the view hierarchy is overhauled to more closely resemble
the final one. This is the new view hierarchy:
ResizableVerticalSplitView)
This PR must be landed with the PRs stacked above it in order not to
break master.
Test Plan
yarn lintyarn flow: no errors in changed codeyarn testKnown issues
intentional; it'll be fixed in a future PR in this stack ([Resize content][3/n] Sync horizontal pan and zoom states #108).
future PR in this stack ([Resize content][2/n] Implement ResizableSplitView #107).