[Resize content][3/n] Sync horizontal pan and zoom states #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2020
taneliang
changed the base branch from
master
to
sttack-architecto-cumque-vitae
kartikcho
approved these changes
Aug 3, 2020
| } from '../canvas/constants'; // TODO: Remove external dependency | ||
|
|
||
| type HorizontalPanAndZoomState = {| | ||
| type HorizontalPanAndZoomState = $ReadOnly<{| |
Member
There was a problem hiding this comment.
Curious, what does $ReadOnly do here?
Member
Author
There was a problem hiding this comment.
It prevents people from reassigning the values of the object. So you can't do e.g. state.offsetX = 234
taneliang
force-pushed
the
sttack-architecto-cumque-vitae
branch
from
3cf668c to
e2b1bfd
Compare
Summary --- Syncs the state of all 3 horizontal pan and zoom views. Fixes the known issue from the first PR in this stack. Test Plan --- * `yarn lint` * `yarn flow`: no errors in changed code * `yarn test`: no new tests; all existing ones passing * `yarn start`: manual test: panning and zooming on any horizontal pan and zoom view also pans and zooms the others.
taneliang
force-pushed
the
sttack-aut-fugiat-id
branch
from
cd39ef4 to
2372ab8
Compare
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/b1wyajgv3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack PR by STACK ATTACK:
Summary
Syncs the state of all 3 horizontal pan and zoom views.
Fixes the known issue from the first PR in this stack.
Test Plan
yarn lintyarn flow: no errors in changed codeyarn test: no new tests; all existing ones passingyarn start: manual test: panning and zooming on any horizontal panand zoom view also pans and zooms the others.