This repository was archived by the owner on May 3, 2021. It is now read-only.
V3.2.11 candidate #183
Merged
V3.2.11 candidate #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create update file to insert `image_overlay_type` field in settings. Write the data display type to the settings table when submitted by the user.
- Validate image overlay type default from Settings
bennettscience
approved these changes
Feb 1, 2019
d7415
suggested changes
Feb 1, 2019
Contributor
d7415
left a comment
d7415
left a comment
There was a problem hiding this comment.
Overall looks good. A few queries. I haven't run it live yet (and need an early night so might not get around to it until tomorrow) but if you have that works for me.
d7415
reviewed
Feb 2, 2019
d7415
approved these changes
Feb 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add different overlays: description and takestamp
Add unlimited time limit for import as an option => Use at your own risk
Fixes #167
Fixes #177
Merged #176 , #178