Skip to content
This repository was archived by the owner on May 3, 2021. It is now read-only.

Conversation

@bennettscience
Copy link
Contributor

Backend and database updates needed to implement #167.

Create update file to insert `image_overlay_type` field
in settings.

Write the data display type to the settings table when submitted
by the user.
@ildyria
Copy link
Member

ildyria commented Jan 29, 2019

I did not test it but this look correct to me.
Before merging we will need the PR in Lychee-front to be merged first. 👍

@d7415
Copy link
Contributor

d7415 commented Jan 29, 2019

I did not test it but this look correct to me.

Ditto

Before merging we will need the PR in Lychee-front to be merged first.

Agreed (for release process, as this takes us to 3.2.11)

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf comment. Aside from that, it looks good to me.

@ildyria
Copy link
Member

ildyria commented Feb 1, 2019

Merged to v3.2.11-candidate.

@ildyria ildyria closed this Feb 1, 2019
@ildyria ildyria mentioned this pull request Feb 1, 2019
@ildyria ildyria added this to the v3.2.11 milestone Feb 3, 2019
@ildyria ildyria deleted the feature/photo-desc branch February 3, 2019 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants