This repository was archived by the owner on May 3, 2021. It is now read-only.
Add setting for php_script_limit. Fixes #177 #178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
approved these changes
Jan 30, 2019
Member
ildyria
left a comment
ildyria
left a comment
There was a problem hiding this comment.
Looks good to me.
We should merge this at the same time as LycheeOrg/Lychee#176
👍
Member
|
Merged to v3.2.11-candidate. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setting to allow for unlimited script run time for LARGE data imports. The values are 1 for on and 0 for off.
Tested using local environment...
With setting "0", 65 photos imported before script timeout of 200 sec.
With setting "1", it is still going at 431 photos...
This can have negative implications if left on, due to giving the script unlimited run time. I would recommend to set to 1 only when needed, and to reset to 0 when done. The default value when database is updated is 0 for off.