-
Notifications
You must be signed in to change notification settings - Fork 6.3k
disable keepalive-workflow because the repo is no longer available #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorkert
approved these changes
Apr 22, 2025
bjornoleh
approved these changes
Apr 22, 2025
ps2
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bjornoleh
added a commit
to bjornoleh/xdripswift
that referenced
this pull request
Apr 22, 2025
The gautamkrishnar/keepalive-workflow has been taken down by GitHub, and GitHub Actions builds are failing due to this. Disabling the keepalive-workflow because the repo is no longer available. A permanent fix will need to be implemented later, this is a bandaid to prevent all build workflows to fail. This is also the same change that was made for LoopWorkspace: LoopKit/LoopWorkspace#248
marionbarker
added a commit
that referenced
this pull request
Apr 23, 2025
* Update LoopWorkspace to 3.5.0 dev Loop * Omnipod changes * Update submodules * Add branch+commit to "What to Test" field in TestFlight. (#97) Adds the branch and last commit to the "What to Test" field in TestFlight to more easily determine the version of each available option in your TestFlight is. * update actions/checkout to v4 (#118) * Update Gemfile.lock for Fastlane 2.223.1 (#207) * update Browser Build features to match main branch * update Loop: restore TestFlight expiration date * update LibreTransmitter: add new libre 2 plus EU sensors * update OmniXXX: pod improvements, protect against 0x31 * update LoopKit: improve visibility for options to select * update to Fastlane 2.225.0 * update using Trio (PR 453) to automate new certificates, credit @bjornoleh * modify time of day for automatic run, deconflict possible nuke cert from other OS apps * update OmniXXX: fix podSuspend logic error, incorporate tryToValidateComms * update actions to use macos 15 and Xcode_16.2 * update Loop: Adjust provisioning profile path in script for Xcode 16 compatibility * Configure the version number in LoopWorkspace, not Loop (#241) * Configure the version number in LoopWorkspace, not Loop * Add VersionOverride for DIY numbering * update Loop: version number change and UI bug fixes * stale values could be displayed for bolus progress total dose * stale values could be displayed for Algorithm Experiment selections * Fix typo in testflight.md build instructions (#240) * Update to fastlane 2.227.1 and Xcode 16.3 (#243) * update G7SensorKit: End of session detection bugfix PR 34 (#244) * update testflight.md, loopdocs links, generic instructions (#245) * update testflight.md, loopdocs links, generic instructions * fix typos in testflight.md * Update submodules (#246) * update G7SensorKit: Fix calibration decoding, lagged backfill processing (#35) * update Loop: bugfixes #2163, #2230 * update LibreTransmitter: support Dependency Build Order * update OmniKit: support Dependency Build Order * update Loop: fix Issue 2168, modify save carb & deliver button * disable keepalive-workflow because the repo is no longer available (#248) * Update to 3.6.0 * update RileyLinkKit: Add build dependencies --------- Co-authored-by: Pete Schwamb <pete@schwamb.net> Co-authored-by: Mike Plante <82073483+MikePlante1@users.noreply.github.com> Co-authored-by: Bastien <bmoulia@gmail.com>
bjornoleh
added a commit
to bjornoleh/xdripswift
that referenced
this pull request
May 1, 2025
The gautamkrishnar/keepalive-workflow has been taken down by GitHub, and GitHub Actions builds are failing due to this. Disabling the keepalive-workflow because the repo is no longer available. A permanent fix will need to be implemented later, this is a bandaid to prevent all build workflows to fail. This is also the same change that was made for LoopWorkspace: LoopKit/LoopWorkspace#248
bjornoleh
added a commit
to bjornoleh/xdripswift
that referenced
this pull request
May 1, 2025
The gautamkrishnar/keepalive-workflow has been taken down by GitHub, and GitHub Actions builds are failing due to this. Disabling the keepalive-workflow because the repo is no longer available. A permanent fix will need to be implemented later, this is a bandaid to prevent all build workflows to fail. This is also the same change that was made for LoopWorkspace: LoopKit/LoopWorkspace#248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The
gautamkrishnar/keepalive-workflow
has been taken down by GitHub.We do not know if this is permanent or not.We now know this is a permanent change.This PR makes a minimal change to the current build_loop.yml which renables building with GitHub actions.
Method
Comment out the section that is not available and insert an echo for the log file.
If we later decide to remove the keepalive process entirely, a bigger change will be made to the build_loop.yml and to the documentation. But for now, I went with the minimum change to make it work.In 60 days, we will need to make a final decision about keepalive.At a later time, the whole logic thread for automatic build will be reviewed, updated and documented.
Testing
This was testing using the loopdocs-tester username both as a branch named disable-keepalive and by renaming it to dev to test the parts of the code that create the alive-xxx branches if they do not exist.