Skip to content

Configure the version number in LoopWorkspace, not Loop #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

marionbarker
Copy link
Contributor

Purpose:

Simplify release process

  • add a version number file to the LoopWorkspace folder and point to it from Version.xcconfig in the Loop folder
  • this requires coordinated PR for Loop and LoopWorkspace

Details

The proposed new file, LoopVersion.xcconfig, for LoopWorkspace is copied from the original Version.xcconfig in the Loop repository.

@marionbarker marionbarker requested review from ps2 and itsmojo March 29, 2025 05:39
Copy link
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be using the existing VersionOverride functionality.

@marionbarker
Copy link
Contributor Author

I modified the PR to use VersionOverride.

This PR must be updated to add the new SHA after Loop PR 2303 is merged.

Copy link
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marionbarker marionbarker merged commit 67e91f7 into dev Apr 7, 2025
1 check was pending
@marionbarker marionbarker deleted the move_version_file branch April 19, 2025 00:49
marionbarker added a commit that referenced this pull request Apr 23, 2025
* Update LoopWorkspace to 3.5.0 dev Loop

* Omnipod changes

* Update submodules

* Add branch+commit to "What to Test" field in TestFlight. (#97)

Adds the branch and last commit to the "What to Test" field in TestFlight to more easily determine the version of each available option in your TestFlight is.

* update actions/checkout to v4 (#118)

* Update Gemfile.lock for Fastlane 2.223.1 (#207)

* update Browser Build features to match main branch

* update Loop: restore TestFlight expiration date

* update LibreTransmitter: add new libre 2 plus EU sensors

* update OmniXXX: pod improvements, protect against 0x31

* update LoopKit: improve visibility for options to select

* update to Fastlane 2.225.0

* update using Trio (PR 453) to automate new certificates, credit @bjornoleh

* modify time of day for automatic run, deconflict possible nuke cert from other OS apps

* update OmniXXX: fix podSuspend logic error, incorporate tryToValidateComms

* update actions to use macos 15 and Xcode_16.2

* update Loop: Adjust provisioning profile path in script for Xcode 16 compatibility

* Configure the version number in LoopWorkspace, not Loop (#241)

* Configure the version number in LoopWorkspace, not Loop
* Add VersionOverride for DIY numbering
* update Loop: version number change and UI bug fixes
   * stale values could be displayed for bolus progress total dose
   * stale values could be displayed for Algorithm Experiment selections

* Fix typo in testflight.md build instructions (#240)

* Update to fastlane 2.227.1 and Xcode 16.3 (#243)

* update G7SensorKit: End of session detection bugfix PR 34 (#244)

* update testflight.md, loopdocs links, generic instructions (#245)

* update testflight.md, loopdocs links, generic instructions

* fix typos in testflight.md

* Update submodules (#246)

* update G7SensorKit: Fix calibration decoding, lagged backfill processing (#35)

* update Loop: bugfixes #2163, #2230

* update LibreTransmitter: support Dependency Build Order

* update OmniKit: support Dependency Build Order

* update Loop: fix Issue 2168, modify save carb & deliver button

* disable keepalive-workflow because the repo is no longer available (#248)

* Update to 3.6.0

* update RileyLinkKit: Add build dependencies

---------

Co-authored-by: Pete Schwamb <pete@schwamb.net>
Co-authored-by: Mike Plante <82073483+MikePlante1@users.noreply.github.com>
Co-authored-by: Bastien <bmoulia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants