Skip to content

Update submodules #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2025
Merged

Update submodules #246

merged 5 commits into from
Apr 19, 2025

Conversation

marionbarker
Copy link
Contributor

@marionbarker marionbarker commented Apr 19, 2025 •
edited
Loading

Purpose

Bring in updates from submodules that are ready to be added to LoopWorkspace

Test

This was tested in my local clone

  • This code was built using Xcode 16.3 on an SE 3rd gen phone running iOS 18.4
  • Loop continued to run successfully using an rPi DASH simulator pump
  • The test suite was executed and all tests passed

Edited to add that all CircleCi tests passed when the final commit was added.
However, some CircleCI tests are failing at GitHub, specifically these two in GlucoseStoreRemoteDataServiceQueryTests:

    ✗ testDataWithUnusedQueryAnchor, Asynchronous wait failed: Exceeded timeout of 2 seconds, with unfulfilled expectations: "Completion".
    ✗ testEmptyWithDefaultQueryAnchor, Asynchronous wait failed: Exceeded timeout of 2 seconds, with unfulfilled expectations: "Completion".

Details

These are the submodule updates included:

  • G7SensorKit 67c5523...46047ed (1):

    Fix calibration decoding, and lagged backfill processing (PR 35)

  • LibreTransmitter f6c2d0f...044cf70 (1):

    Add build dependencies (PR 20)

  • Loop 0a3a1651...e45f1376 (3):

    Update meal label, proposed remedy for Issue #2168 (#2300)
    Issue 2218 add emoji to foodType (PR 2230)
    Use full ICE history for displaying estimated carbohydrate effects (PR 2163)

  • OmniKit 39915b0...92948a7 (1):

    Merge pull request PR 50 from kingst/main

@marionbarker marionbarker requested a review from ps2 April 19, 2025 01:59
@marionbarker marionbarker mentioned this pull request Apr 19, 2025
Merged
ps2
ps2 approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marionbarker
Copy link
Contributor Author

Loop PR 2300 was also approved by @ps2 so added that to this PR to bring fixes into dev with this one PR.

@marionbarker marionbarker merged commit 898fd08 into dev Apr 19, 2025
1 check passed
@marionbarker marionbarker deleted the update_submodules branch April 19, 2025 22:39
marionbarker added a commit that referenced this pull request Apr 23, 2025
@marionbarker @ps2
@MikePlante1 @bastienmoulia
Release/3.6.0 (#249)
adaa2a1 
* Update LoopWorkspace to 3.5.0 dev Loop

* Omnipod changes

* Update submodules

* Add branch+commit to "What to Test" field in TestFlight. (#97)

Adds the branch and last commit to the "What to Test" field in TestFlight to more easily determine the version of each available option in your TestFlight is.

* update actions/checkout to v4 (#118)

* Update Gemfile.lock for Fastlane 2.223.1 (#207)

* update Browser Build features to match main branch

* update Loop: restore TestFlight expiration date

* update LibreTransmitter: add new libre 2 plus EU sensors

* update OmniXXX: pod improvements, protect against 0x31

* update LoopKit: improve visibility for options to select

* update to Fastlane 2.225.0

* update using Trio (PR 453) to automate new certificates, credit @bjornoleh

* modify time of day for automatic run, deconflict possible nuke cert from other OS apps

* update OmniXXX: fix podSuspend logic error, incorporate tryToValidateComms

* update actions to use macos 15 and Xcode_16.2

* update Loop: Adjust provisioning profile path in script for Xcode 16 compatibility

* Configure the version number in LoopWorkspace, not Loop (#241)

* Configure the version number in LoopWorkspace, not Loop
* Add VersionOverride for DIY numbering
* update Loop: version number change and UI bug fixes
   * stale values could be displayed for bolus progress total dose
   * stale values could be displayed for Algorithm Experiment selections

* Fix typo in testflight.md build instructions (#240)

* Update to fastlane 2.227.1 and Xcode 16.3 (#243)

* update G7SensorKit: End of session detection bugfix PR 34 (#244)

* update testflight.md, loopdocs links, generic instructions (#245)

* update testflight.md, loopdocs links, generic instructions

* fix typos in testflight.md

* Update submodules (#246)

* update G7SensorKit: Fix calibration decoding, lagged backfill processing (#35)

* update Loop: bugfixes #2163, #2230

* update LibreTransmitter: support Dependency Build Order

* update OmniKit: support Dependency Build Order

* update Loop: fix Issue 2168, modify save carb & deliver button

* disable keepalive-workflow because the repo is no longer available (#248)

* Update to 3.6.0

* update RileyLinkKit: Add build dependencies

---------

Co-authored-by: Pete Schwamb <pete@schwamb.net>
Co-authored-by: Mike Plante <82073483+MikePlante1@users.noreply.github.com>
Co-authored-by: Bastien <bmoulia@gmail.com>
@Muppet1313 Muppet1313 mentioned this pull request Apr 23, 2025
Closed
@bastienmoulia bastienmoulia mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps2 ps2 ps2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marionbarker @ps2