Dev #387
Closed
Dev #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register the "Loop" app url scheme in order to make the app an addressable target.
Resolve #319: tapping the widget opens the app
Fix broken build.
Fix widget battery level for x22 pumps
Update RL frameworks to 0.13
* Rough cut at moving HUD views into their own framework. * Move view code into the HUDViewKit framework directory * Remove HUDViewKit * Add GlucoseTrend and NSTimeInterval directly to WatchApp Extension so that it doesn't have to pull in HUDViewKit * Get all targets to compile with HUDViewKit 1. Make HKUnit extension internal and included it directly into all necessary targets to avoid a conflict with the same extension in LoopKit 2. Publicize any necessary HUDViewKit vars, funcs 3. Store the Int raw value for GlucoseTrend in WatchContext and create a computed property that returns it as a GlucoseTrend object to avoid the conflict where both Loop and WatchApp Extension have their own separate concept of GlucoseTrend. * Rename HUDViewKit to LoopUI * partway through moving layout * WIP * Resize stack view to fill container view * Embed LoopUI framework * Use NibLoadable for HUDView
* Monitor changes and update the widget in real time. Use KVO to watch the UserDefaults object and update the view as appropriate. * Clean up observer implementation 1. call addObserver() in viewDidLoad() 2. call removeObserver() in deinit 3. don't specify options in addObserver() 4. provide a context to the observer code * Move early-return semantics into a guard statement. * Use an explicit, separately named context for observer.
* Use a clear fill color for the circle. * Oops! Forgot to set the clear color for init?(coder:) as well
…archy (#352) * Rough cut at moving HUD views into their own framework. * Move view code into the HUDViewKit framework directory * Remove HUDViewKit * Add GlucoseTrend and NSTimeInterval directly to WatchApp Extension so that it doesn't have to pull in HUDViewKit * Get all targets to compile with HUDViewKit 1. Make HKUnit extension internal and included it directly into all necessary targets to avoid a conflict with the same extension in LoopKit 2. Publicize any necessary HUDViewKit vars, funcs 3. Store the Int raw value for GlucoseTrend in WatchContext and create a computed property that returns it as a GlucoseTrend object to avoid the conflict where both Loop and WatchApp Extension have their own separate concept of GlucoseTrend. * Rename HUDViewKit to LoopUI * partway through moving layout * WIP * Resize stack view to fill container view * Embed LoopUI framework * Use NibLoadable for HUDView * Create a "Common" group for all files with membership in multiple targets.
* Disable animation on first render, since we'd be animating from a default value so the animation is deceptive. * Use the more specific TimeInterval type for duration
* Enforce a fixed number of fractional digits per unit type. At all times, we prefer: 0 fractional digits for mg/dL 1 fractional digit eliminate the use of significant digits and use fixed a number of fractional digits everywhere. This is in service of: #324 * Pass the glucose NumberFormatter directly into the chart This lets us back out the changes to PredictionTableViewController since now the ChartAxisDoubleUnit uses the glucose formatter to represent its value instead of hardcoding an integer formatter.
…t launch Loop app (#363)
* Only allow one active glucose data source Separate CGM sources out into their own section and enforce zero or one active sources at any given time. This requires a new boolean value to track whether the G5 transmitter is enabled independently of the actual transmitter ID. While we're at it, create a separate config section for the pump to group it with the pump battery type since those are not really configuration values and go together. * Improve animation mode for showing G5 Transmitter ID The top animation is a clearer indication that this is an extension of the G5 Transmitter enabled switch. * Be more specific with the key name * Use 'CGM' instead of 'Cgm' * Mark target-action methods with @objc to make sure that they're using dynamic dispatch. Also make the internal methods private for good measure.
Signing frameworks at build time is not recommended so disable code signing for LoopUI. All changes performed automatically by XCode
* Fetch cgm data from x22 pump * Add fetch glucose flag * Add SensorDisplayable wrapper for pump glucose history events * Restructure glucose history handling * Rename functions to Enlite to improve clarity Group Enlite functions and data together * Add pumpDataIsStale, move enlite fetch into timer tick Rename user default key * Keep stale glucose check to avoid fetching enlite pages too often
* remove +ve momentum from bolus calculation * add logging, set prediction to nil when inputs change
* Configurable minimum bg guard. * Fix display issues, and clear out stored value when user deletes entry via interface * Return recommendation structure * Adding more context to bolus screen * Update bolus notices. * another rev of the bolus ui, showing eventualbg, iob, pending insulin, cob, and more succinct warnings * Update tests * Update tests * Configurable minimum bg guard. * Fix display issues, and clear out stored value when user deletes entry via interface * Return recommendation structure * Adding more context to bolus screen * Update bolus notices. * another rev of the bolus ui, showing eventualbg, iob, pending insulin, cob, and more succinct warnings * Update tests * Update tests * DoseMath.recommendBolusFromPredictedGlucose doesn't take lastTempBasal * Add HKUnit to DoseMathTests * Move BolusRecommendation notice to enum * Revert defaultAbsorptionTimes * Avoid rounding above pump delivery resolution for small boluses * Assume the entirety of BolusViewController is not thread-safe, and do dispatch to main thread in StatusViewController * Make loopManager.getPendingInsulin private, and pass pending insulin via BolusRecommendation * Use NumberFormatter.glucoseFormatter for glucose display when setting Minimum BG Guard * Use DateComponentsFormatter for formatting age in minutes * Use if case for single enum comparisons * Avoid reloading tableview with static cells * Add new method for displaying glucose with units. * Add warning symbol * Warning symbol was showing unecessarily in some cases * Update minimumBGGuard for new settings layout * remove debug print * Remove unnecessary dispatches * Let date components formatter add units string. * Unify how notice label is set * Add resizing constraints to notice label * Store age errors as dates for more accurate error messaging
Update LoopKit and Rileylink frameworks
Bump version
… guard, as it is a new configuration setting
Show last loop error on clicking loop status
Bolus ui updates
…e complication time to relative time. (#379) * Adds support for mmol in watch app. Changes complication time to relative. Adds modularLarge complication. * Fix gallery and tabs
|
Guessing this was created in error. |
ps2
pushed a commit
that referenced
this pull request
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.