Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #319: tapping the widget opens the app #334

Merged
merged 3 commits into from
Dec 25, 2016
Merged

Conversation

bharat
Copy link

@bharat bharat commented Dec 23, 2016

Register the "Loop" app url scheme in order to make the app an addressable target.

Register the "Loop" app url scheme in order to make the app an addressable target.
@bharat
Copy link
Author

bharat commented Dec 23, 2016

this resolves #319 - adding this comment to link the two.

<dict>
<key>CFBundleURLSchemes</key>
<array>
<string>Loop</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase would be preferred. Any idea if this will create conflicts with another app?

Alternatively you could derive something unique using the bundle identifier, which will be nice for the few folks who have multiple installations.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some searching and couldn't find a canonical repository, and since "loop" is 4 characters I'm positive there's a conflict out there somewhere. I just pushed a change to use MAIN_APP_BUNDLE_IDENTIFIER, so the URL now looks like: "com.loopkit.Loop://".

It works in the simulator. Haven't tested it on my device yet.


var mainAppUrl: URL? {
if let mainAppBundleIdentifier = mainAppBundleIdentifier {
return URL(string: mainAppBundleIdentifier + "://")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"\(mainAppBundleIdentifier)://"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. fixed.

@ps2 ps2 merged commit 67f0c3d into LoopKit:dev Dec 25, 2016
@bharat bharat deleted the tap-opens-app branch January 2, 2017 02:30
ps2 pushed a commit that referenced this pull request Nov 25, 2020
* type casting to display the mock pump HUD view

* define mock pump manager conformance to PumpManagerUI as soon as possible

* removed unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants