Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HUD views into a framework #284

Closed
bharat opened this issue Nov 28, 2016 · 1 comment
Closed

Refactor HUD views into a framework #284

bharat opened this issue Nov 28, 2016 · 1 comment

Comments

@bharat
Copy link

bharat commented Nov 28, 2016

Once #281 is complete, we'll be sharing HUD views across Loop and the Loop Status Extension. Refactor the views into a framework that can be shared across the two apps so that they're not duplicated.

ps2 pushed a commit that referenced this issue Jan 1, 2017
* Rough cut at moving HUD views into their own framework.

* Move view code into the HUDViewKit framework directory

* Remove HUDViewKit

* Add GlucoseTrend and NSTimeInterval directly to WatchApp Extension so that it doesn't have to pull in HUDViewKit

* Get all targets to compile with HUDViewKit

1. Make HKUnit extension internal and included it directly into all
   necessary targets to avoid a conflict with the same extension in
   LoopKit

2. Publicize any necessary HUDViewKit vars, funcs

3. Store the Int raw value for GlucoseTrend in WatchContext and create
   a computed property that returns it as a GlucoseTrend object to avoid
   the conflict where both Loop and WatchApp Extension have their own
   separate concept of GlucoseTrend.

* Rename HUDViewKit to LoopUI

* partway through moving layout

* WIP

* Resize stack view to fill container view

* Embed LoopUI framework

* Use NibLoadable for HUDView
@Kdisimone
Copy link
Collaborator

merged and completed

ps2 pushed a commit that referenced this issue Nov 16, 2020
* ensuring any potential y-axis label is not displayed as -0

* clarified comments

* values that may be displayed as 0 should truly be 0

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants