fix(linux/audio): don't set pulseaudio buffer size#2999
Merged
ReenigneArcher merged 1 commit intoLizardByte:masterfrom Aug 9, 2024
Merged
fix(linux/audio): don't set pulseaudio buffer size#2999ReenigneArcher merged 1 commit intoLizardByte:masterfrom
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
Conversation
We only care for fragment size anyway and don't pace consumption. Should hopefully fix audio cracking in pipewire-pulseaudio.
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2999 +/- ##
=========================================
+ Coverage 9.57% 9.69% +0.11%
=========================================
Files 73 97 +24
Lines 13616 17524 +3908
Branches 6263 8204 +1941
=========================================
+ Hits 1304 1699 +395
- Misses 9737 15042 +5305
+ Partials 2575 783 -1792
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
Got the confirmation that it fixes the pipewire related bug, should be ok to merge. |
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Oct 9, 2024
c2vi
pushed a commit
to c2vi/Sunshine
that referenced
this pull request
Mar 27, 2025
Nonary
pushed a commit
to Nonary/vibeshine
that referenced
this pull request
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't set pulseaudio buffer size.
We only care for fragment size anyway and don't pace consumption.
Should hopefully fix audio cracking in pipewire-pulseaudio.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist