Skip to content

fix(linux/audio): don't set pulseaudio buffer size #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Aug 9, 2024
Merged

fix(linux/audio): don't set pulseaudio buffer size #2999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/platform/linux/audio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,13 @@ namespace platf {
channel = position_mapping[*mapping++];
});

pa_buffer_attr pa_attr = {};
pa_attr.fragsize = frame_size * channels * sizeof(float);
pa_attr.maxlength = pa_attr.fragsize * 2;
pa_buffer_attr pa_attr = {
.maxlength = uint32_t(-1),
.tlength = uint32_t(-1),
.prebuf = uint32_t(-1),
.minreq = uint32_t(-1),
.fragsize = uint32_t(frame_size * channels * sizeof(float))

Check failure

Code scanning / CodeQL

Multiplication result converted to larger type

Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'.
};

int status;

Expand Down