CI: sanity check for req. pkgs #11819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
SeanNaren,
awaelchli,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
tchaton and
williamFalcon
as code owners
rohitgr7
approved these changes
Feb 9, 2022
carmocca
reviewed
Feb 9, 2022
Contributor
carmocca
left a comment
carmocca
left a comment
There was a problem hiding this comment.
I don't think we need this. All this information is already printed
akihironitta
approved these changes
Feb 10, 2022
Contributor
|
As #11811 is merged into master, all running jobs here should be green now 👀 |
carmocca
reviewed
Feb 10, 2022
carmocca
reviewed
Feb 10, 2022
carmocca
reviewed
Feb 10, 2022
carmocca
approved these changes
Feb 11, 2022
carmocca
reviewed
Feb 11, 2022
carmocca
reviewed
Feb 11, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
for more information, see https://pre-commit.ci
This reverts commit 1641ccb.
* enable PT 1.11 * horovod * Apply suggestions from code review Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Aki Nitta <nitta@akihironitta.com>
awaelchli
approved these changes
Mar 10, 2022
carmocca
reviewed
Mar 13, 2022
| import horovod.torch | ||
|
|
||
| # returns an error code | ||
| assert horovod.torch.nccl_built() |
Contributor
There was a problem hiding this comment.
This assertion is failing and blocking master:
Extension horovod.torch has not been built: /usr/local/lib/python3.7/dist-packages/horovod/torch/mpi_lib/_mpi_lib.cpython-37m-x86_64-linux-gnu.so not found
If this is not expected, reinstall Horovod with HOROVOD_WITH_PYTORCH=1 to debug the build error.
Warning! MPI libs are missing, but python applications are still available.
Traceback (most recent call last):
File "requirements/check-avail-strategies.py", line 7, in <module>
assert horovod.torch.nccl_built()
AttributeError: module 'horovod.torch' has no attribute 'nccl_built'
Collaborator
Author
There was a problem hiding this comment.
ok, so it seems it is working as expected :)
what kind of jobs is failing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
it shall prevent situations like #11811 when we were silently skipping some tests which shall be running
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @carmocca @akihironitta