Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Feb 7, 2022

What does this PR do?

Enable testing for PT 1.11 when it becomes available as wheel for testing

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @akihironitta @carmocca @Borda

@Borda Borda added the ci Continuous Integration label Feb 7, 2022
@Borda Borda requested a review from carmocca February 7, 2022 15:20
@Borda Borda requested a review from tchaton as a code owner February 7, 2022 15:20
@Borda Borda marked this pull request as draft February 7, 2022 15:21
@Borda Borda changed the title CI: enable testing for PT 1.11 CI: enable testing for PT 1.11 [wip] Feb 7, 2022
@Borda
Copy link
Collaborator Author

Borda commented Feb 7, 2022

well, need to be full PR to run also Conda and full test where this change is defacto implemented... 🐰

@carmocca carmocca marked this pull request as ready for review February 7, 2022 15:33
@carmocca carmocca added this to the 1.6 milestone Feb 7, 2022
@carmocca carmocca added the priority: 0 High priority task label Feb 7, 2022
@Borda
Copy link
Collaborator Author

Borda commented Feb 7, 2022

seems that it was removed from the nighty channel but still was not added to the test channel 🐰

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #11792 (fbe0f64) into master (6309a59) will decrease coverage by 4%.
The diff coverage is n/a.

❗ Current head fbe0f64 differs from pull request most recent head 5f53dfa. Consider uploading reports for the commit 5f53dfa to get more accurate results

@@           Coverage Diff            @@
##           master   #11792    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         205      198     -7     
  Lines       17514    17326   -188     
========================================
- Hits        16061    15190   -871     
- Misses       1453     2136   +683     

@Borda Borda changed the title CI: enable testing for PT 1.11 [wip] CI: enable testing for PT 1.11 Mar 2, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 3, 2022
@Borda
Copy link
Collaborator Author

Borda commented Mar 7, 2022

ok, seems it is blocked by enabling horovod>=0.24 in #12248

@mergify mergify bot removed the has conflicts label Mar 10, 2022
@Borda Borda merged commit 3b4061f into master Mar 10, 2022
@Borda Borda deleted the ci/pt-1.11 branch March 10, 2022 18:38
Borda added a commit that referenced this pull request Mar 10, 2022
* enable PT 1.11
* horovod
* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Aki Nitta <nitta@akihironitta.com>
Borda added a commit that referenced this pull request Mar 10, 2022
* enable PT 1.11
* horovod
* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Aki Nitta <nitta@akihironitta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants