-
Notifications
You must be signed in to change notification settings - Fork 3.6k
CI: enable testing for PT 1.11 #11792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
well, need to be full PR to run also Conda and full test where this change is defacto implemented... 🐰 |
|
seems that it was removed from the nighty channel but still was not added to the test channel 🐰 |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #11792 +/- ##
========================================
- Coverage 92% 88% -4%
========================================
Files 205 198 -7
Lines 17514 17326 -188
========================================
- Hits 16061 15190 -871
- Misses 1453 2136 +683 |
|
ok, seems it is blocked by enabling |
* enable PT 1.11 * horovod * Apply suggestions from code review Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Aki Nitta <nitta@akihironitta.com>
* enable PT 1.11 * horovod * Apply suggestions from code review Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Aki Nitta <nitta@akihironitta.com>
What does this PR do?
Enable testing for PT 1.11 when it becomes available as wheel for testing
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @tchaton @rohitgr7 @akihironitta @carmocca @Borda