Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Feb 8, 2022

What does this PR do?

Fixes a similar problem to #11596, but the issue is horovod this time.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @akihironitta @carmocca @Borda

@akihironitta
Copy link
Contributor Author

akihironitta commented Feb 8, 2022

Watching if pip list in Docker / build-CUDA (3.7, 1.8) (pull_request) shows horovod.
https://github.com/PyTorchLightning/pytorch-lightning/runs/5112572709?check_suite_focus=true

@Borda Borda added bug Something isn't working priority: 0 High priority task labels Feb 8, 2022
@Borda
Copy link
Collaborator

Borda commented Feb 8, 2022

@akihironitta very nice, just adding sanity checks that the installed packages are available (can be imported)

@akihironitta akihironitta added this to the 1.5.x milestone Feb 8, 2022
@akihironitta akihironitta changed the title [wip] Fix horovod installation base-cuda Dockerfile Fix horovod installation base-cuda Dockerfile Feb 8, 2022
@akihironitta akihironitta added the ci Continuous Integration label Feb 8, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 8, 2022
@mergify mergify bot requested a review from a team February 8, 2022 17:26
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda Borda mentioned this pull request Feb 9, 2022
12 tasks
@akihironitta akihironitta merged commit 0a1b8b8 into master Feb 10, 2022
@akihironitta akihironitta deleted the ci/base-cuda-horovod branch February 10, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants