-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid in-place ops during logging result updates #11401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
priority: 0
High priority task
logging
Related to the `LoggerConnector` and `log()`
labels
Jan 10, 2022
carmocca
requested review from
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
January 10, 2022 17:10
rohitgr7
approved these changes
Jan 10, 2022
ananthsub
approved these changes
Jan 11, 2022
awaelchli
approved these changes
Jan 11, 2022
Borda
approved these changes
Jan 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #11401 +/- ##
========================================
- Coverage 92% 88% -4%
========================================
Files 194 194
Lines 16936 16981 +45
========================================
- Hits 15555 14964 -591
- Misses 1381 2017 +636 |
tchaton
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
carmocca
added a commit
that referenced
this pull request
Jan 12, 2022
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
lexierule
pushed a commit
that referenced
this pull request
Jan 19, 2022
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
logging
Related to the `LoggerConnector` and `log()`
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11386
This is caused by:
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @Borda @tchaton @rohitgr7 @carmocca @edward-io @ananthsub @kamil-kaczmarek @Raalsky @Blaizzy