-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly Patch Release v1.5.10 #11789
Closed
Closed
Weekly Patch Release v1.5.10 #11789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed
* Don't store csv.Dictwriter in ExperimentWriter * Add test for pickle after .save() * Add entry in changelog
* disable step logging in epoch hooks * chlog * Apply suggestions from code review * chlog
Co-authored-by: Kaushik Bokka <kaushikbokka@gmail.com>
* fix * less code * add test case * add test cases * update input * add test cases * add type hint * add changelog note Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
…#10432) Co-authored-by: Thomas Chaton <thomas@grid.ai>
…#10434) Co-authored-by: Thomas Chaton <thomas@grid.ai>
for more information, see https://pre-commit.ci
#10374) Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com> Co-authored-by: Thomas Chaton <thomas@grid.ai>
…tion` (#9702) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carmocca@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Andrew Tritt <andrew.j.tritt@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
rohitgr7
requested review from
awaelchli,
Borda,
carmocca,
edenlightning,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
February 7, 2022 14:06
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply_to_collection(defaultdict)
(Fixapply_to_collection(defaultdict)
#10316)DataLoader(batch_size=None)
is passed (Fix failure whenDataLoader(batch_size=None)
is passed #10345)persistent_workers=True
(Resolve workers being forcelly deleted withpersistent_workers=True
#10434)apply_to_collection
(Fix support for dataclasses with ClassVar/InitVar inapply_to_collection
#9702)to_torchscript()
causing false positive deprecation warnings (Fixto_torchscript()
causing false positive deprecation warnings #10470)RichProgressBarTheme
dataclass (Change attributes ofRichProgressBarTheme
dataclass #10454)LightningModule.log
(Fix an issue that caused Lightning to extract the batch size even though it was set by the user inLightningModule.log
#10408)self.log
(Respect the passed dtype withself.log
#10076)move_metrics_to_cpu
with evaluation (Fixmove_metrics_to_cpu
with evaluation #10631)SignalConnector._has_already_handler
check for callable type (Fix SignalConnector._has_already_handler check for callable type #10483)LightningModule
(Fix support for logging within callbacks returned fromLightningModule
#10991)CombinedLoader
while checking for warning raised with eval dataloaders (Fix support forCombinedLoader
while checking for warning raised with eval dataloaders #10994)on_train_epoch_end
(Update the TQDM progress baron_train_epoch_end
#11069)onnx.export(example_outputs=...)
in torch 1.10 (Avoid the deprecatedonnx.export(example_outputs=...)
in torch 1.10 #11116)trainer.logger
(Add typing fortrainer.logger
#11114)on_fit_start
hook (Refactor plugin tests whose assertions don't need to run inon_fit_start
hook #11149)PredictionEpochLoop
(Suppress Warning inPredictionEpochLoop
#11189)_should_reload_dl_epoch
causing inconsistent validation dataloader reloading (Fix_should_reload_dl_epoch
causing inconsistent validation dataloader reloading #11036)IterableDataset
(Disable attaching samplers when usingIterableDataset
#11507)What does this PR do?
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃