Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Patch Release v1.5.10 #11789

Closed
wants to merge 123 commits into from
Closed

Weekly Patch Release v1.5.10 #11789

wants to merge 123 commits into from

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Feb 7, 2022

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

carmocca and others added 30 commits November 9, 2021 12:35
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed

* Only import PostLocalSGD related modules when it's needed
* Don't store csv.Dictwriter in ExperimentWriter

* Add test for pickle after .save()

* Add entry in changelog
* disable step logging in epoch hooks

* chlog

* Apply suggestions from code review

* chlog
Co-authored-by: Kaushik Bokka <kaushikbokka@gmail.com>
* fix

* less code

* add test case

* add test cases

* update input

* add test cases

* add type hint

* add changelog note

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
#10374)

Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Thomas Chaton <thomas@grid.ai>
…tion` (#9702)

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
awaelchli and others added 13 commits January 5, 2022 10:12
Co-authored-by: Carlos Mocholi <carmocca@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Andrew Tritt <andrew.j.tritt@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rohitgr7 rohitgr7 closed this Feb 7, 2022
@rohitgr7 rohitgr7 deleted the 1.5.10-draft branch February 7, 2022 14:07
@mergify mergify bot added the has conflicts label Feb 7, 2022
@rohitgr7 rohitgr7 restored the 1.5.10-draft branch February 7, 2022 14:09
@Borda Borda reopened this Feb 7, 2022
@rohitgr7 rohitgr7 closed this Feb 7, 2022
@rohitgr7 rohitgr7 deleted the 1.5.10-draft branch February 7, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.