Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin tests whose assertions don't need to run in on_fit_start hook #11149

Merged
merged 6 commits into from
Dec 18, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 18, 2021

What does this PR do?

Preparation for #11137

There are a number of tests of this form:

class CB(Callback):
    def on_fit_start(self, trainer):
        assert "something that doesn't require fit()"
        raise Error()

trainer = Trainer(callbacks=CB()) 
with pytest.raises(Error):
    trainer.fit()

These can actually be written without relying on the on_fit_start hook, like so:

trainer = Trainer(callbacks=CB()) 
assert "something that doesn't require fit()"

The tests are a prehistoric artifact from a time when many accelerator related settings like global_rank etc. were not available upon trainer instantiation.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @justusschock @awaelchli @akihironitta @Borda

@awaelchli awaelchli added this to the 1.5.x milestone Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #11149 (b1b0cdd) into master (62f1e82) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #11149    +/-   ##
========================================
+ Coverage      88%      92%    +4%     
========================================
  Files         177      177            
  Lines       16526    16551    +25     
========================================
+ Hits        14580    15218   +638     
+ Misses       1946     1333   -613     

@mergify mergify bot added the ready PRs ready to be merged label Dec 18, 2021
@awaelchli awaelchli merged commit a3e2ef2 into master Dec 18, 2021
@awaelchli awaelchli deleted the refactor/spawn/pre-dispatch-tests branch December 18, 2021 22:38
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants