-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor plugin tests whose assertions don't need to run in on_fit_start
hook
#11149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
December 18, 2021 02:15
ananthsub
approved these changes
Dec 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #11149 +/- ##
========================================
+ Coverage 88% 92% +4%
========================================
Files 177 177
Lines 16526 16551 +25
========================================
+ Hits 14580 15218 +638
+ Misses 1946 1333 -613 |
carmocca
approved these changes
Dec 18, 2021
rohitgr7
approved these changes
Dec 18, 2021
rohitgr7
pushed a commit
that referenced
this pull request
Dec 20, 2021
awaelchli
added a commit
that referenced
this pull request
Dec 21, 2021
lexierule
pushed a commit
that referenced
this pull request
Dec 21, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preparation for #11137
There are a number of tests of this form:
These can actually be written without relying on the on_fit_start hook, like so:
The tests are a prehistoric artifact from a time when many accelerator related settings like global_rank etc. were not available upon trainer instantiation.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @justusschock @awaelchli @akihironitta @Borda