Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for help #1

Closed
shreyasbapat opened this issue Apr 1, 2019 · 11 comments · Fixed by #10827 or #10913
Closed

Proposal for help #1

shreyasbapat opened this issue Apr 1, 2019 · 11 comments · Fixed by #10827 or #10913

Comments

@shreyasbapat
Copy link
Contributor

Hi @williamFalcon ! I saw your project and I am very pleased by the idea. I wish to help you writing production level code. PLease let me know in what way can I help!

@williamFalcon
Copy link
Contributor

Sounds great. can you send me a pm on twitter? we can coordinate through there _willfalcon

@shreyasbapat
Copy link
Contributor Author

Seems like on twitter both the sides have to follow each other in order to share PMs. Any other platform?

@williamFalcon
Copy link
Contributor

good point haha. didn't know that about twitter. I've added you anyhow, but let's just chat here.

First step to helping is for you to do the following things and document your experience such as what was hard, what was not intuitive, what documentation would be helpful, etc.

  1. Build and run the demo.
  2. Build a simple classifier on your own using this.

From there we can see where the gaps are in usability and documentation. Then we can make a dev plan to get those things fixed in the library.

How does that sound? What's a good ETA to get that done?

Thanks!

@shreyasbapat
Copy link
Contributor Author

Yes. I will do these after this week only. (I am too busy this week)

Anyways, the things that majorly concern me is the organisation of the package. You can have a look at my other library (Not related to DL) EinsteinPy, but you can have a look at how extensively its tested etc.

From there we can see where the gaps are in usability and documentation. Then we can make a dev plan to get those things fixed in the library.

For this plan, I will get back to you this Tuesday?

@williamFalcon
Copy link
Contributor

Sounds great. Yeah, this is a research library, so I didn't write tests for it because I've been moving quickly through research for publication. Tests would be great! I have however tested it myself when using/coding it, just didn't write an explicit test out.

Writing code for research has a less rigorous approach than code for a production system haha.

@shreyasbapat
Copy link
Contributor Author

I have however tested it myself when using/coding it, just didn't write an explicit test out.

No issues! I would love to help. I will make some organisational changes in a PR, for making docs and CI easy! Is that fine?

@williamFalcon
Copy link
Contributor

perfect. Looking forward!

@shreyasbapat
Copy link
Contributor Author

One question. Why is the package name pytorch_lightning somewhere and pytorch-lightning somewhere else?

@shreyasbapat
Copy link
Contributor Author

Oh! I am sorry, the tuesday thing got slipped off my mind. Will do this shortly :)

@williamFalcon
Copy link
Contributor

Hi! lighting has been updated to include: tensorboard visualization, multi-gpu training, multi-node training, thoroughly documented and updated clean syntax.

Would be auper helpful if you tried version 0.21 and provided feedback!

Thanks!

luiscape pushed a commit to luiscape/pytorch-lightning that referenced this issue Jan 17, 2020
[PYT-119] Add global link variables
luiscape pushed a commit to luiscape/pytorch-lightning that referenced this issue Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants
@williamFalcon @shreyasbapat and others