Revert "[CI] Comment flaky tests (#10084)"

[akihironitta]

This reverts commit ed98026.

What does this PR do?

• Removes unnecessary standalone=True. (without this flag, conda jobs used to frequently fail as tracked in CI: conda 1.9 and 1.10 getting killed #10129)
• Closes Remove pytest-random-order from conda tests #10515.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• [n/a] Did you make sure to update the documentation with your changes? (if necessary)
• [n/a] Did you write any new necessary tests? (not for typos and docs)
• [n/a] Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

[codecov]

Codecov Report

Merging #10580 (1dbb6c1) into master (28ce910) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10580   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         177      177           
  Lines       16760    16760           
=======================================
  Hits        15407    15407           
  Misses       1353     1353           

[akihironitta]

will continue to investigate this in akihironitta#2.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

[tchaton]

Hey @akihironitta,

Any updates on this one ?

[akihironitta]

Still WIP but to run CI jobs, I'll mark this PR as ready for review.

UPDATE: This PR should be ready for your reviews now as the test seems to have passed.

[akihironitta]

Could someone add this to an appropriate milestone?

[awaelchli]

@akihironitta In order to know that it's no longer flaky, we need to rerun it several times

[akihironitta]

@awaelchli I'll rerun the conda jobs (which were previously failing) three times now. Does that sound reasonable?

Update: All three sequential runs were successful:
https://github.com/PyTorchLightning/pytorch-lightning/actions/runs/1609243325/attempts/1
https://github.com/PyTorchLightning/pytorch-lightning/actions/runs/1609243325/attempts/2
https://github.com/PyTorchLightning/pytorch-lightning/actions/runs/1609243325/attempts/3