Skip to content

Commit

Permalink
Revert "Revert "[CI] Comment flaky tests (#10084)""
Browse files Browse the repository at this point in the history
This reverts commit 95064ec.
  • Loading branch information
akihironitta committed Nov 18, 2021
1 parent 73225bb commit b68c923
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/ci_test-conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
python ./requirements/adjust_versions.py requirements/extra.txt
python ./requirements/adjust_versions.py requirements/examples.txt
pip install --requirement requirements/devel.txt --find-links https://download.pytorch.org/whl/nightly/torch_nightly.html
pip install pytest-random-order
pip list
- name: Pull checkpoints from S3
Expand All @@ -42,7 +43,7 @@ jobs:
- name: Tests
run: |
# NOTE: run coverage on tests does not propagate failure status for Win, https://github.com/nedbat/coveragepy/issues/1003
coverage run --source pytorch_lightning -m pytest pytorch_lightning tests -v --durations=50 --junitxml=junit/test-results-${{ runner.os }}-torch${{ matrix.pytorch-version }}.xml
coverage run --source pytorch_lightning -m pytest --random-order-seed=1 pytorch_lightning tests -v --durations=50 --junitxml=junit/test-results-${{ runner.os }}-torch${{ matrix.pytorch-version }}.xml
shell: bash -l {0}

- name: Upload pytest results
Expand Down
1 change: 1 addition & 0 deletions tests/profiler/test_profiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ def test_pytorch_profiler_trainer_ddp(tmpdir, pytorch_profiler):
assert any(f"{local_rank}-validation_step" in f for f in files)


@RunIf(special=True)
@pytest.mark.parametrize("fast_dev_run", [1, 2, 3, 4, 5])
@pytest.mark.parametrize("boring_model_cls", [ManualOptimBoringModel, BoringModel])
def test_pytorch_profiler_trainer_fit(fast_dev_run, boring_model_cls, tmpdir):
Expand Down

0 comments on commit b68c923

Please sign in to comment.