Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix propagation of device and dtype properties in Lite modules #10559

Merged
merged 11 commits into from
Nov 16, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 16, 2021

What does this PR do?

Fixes #10556

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda

@awaelchli awaelchli added bug Something isn't working fabric lightning.fabric.Fabric labels Nov 16, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Nov 16, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2021
@awaelchli awaelchli enabled auto-merge (squash) November 16, 2021 14:41
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #10559 (e23368c) into master (af4af3d) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10559   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         178      178           
  Lines       16248    16249    +1     
=======================================
+ Hits        14907    14908    +1     
  Misses       1341     1341           

@awaelchli awaelchli mentioned this pull request Nov 16, 2021
11 tasks
@awaelchli awaelchli merged commit d50e169 into master Nov 16, 2021
@awaelchli awaelchli deleted the bugfix/lite-device branch November 16, 2021 17:26
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightningLite not updating DeviceDtypeModuleMixin correctly
5 participants