upgrade to leveldb-1.19

[juliangruber]

This is a work in progress pull request for #298

The build is currently failing.

[juliangruber]

Build and tests now pass in my setup!

[juliangruber]

We should create a .patch file for the floating port_uv.h patch

[juliangruber]

Tests pass now on travis too. We can decide about adding new features in another pull request.

What do you all think? Should we do more manual testing? Manual inspection?

[ralphtheninja]

💯

[chjj]

@juliangruber, great work.

Maybe we can merge it in to master, but hold off on publishing to npm for a little while? Either way, I'll be testing this thoroughly in practice for the next few days.

[ralphtheninja]

@juliangruber I guess this would mean a 1.4.7 release right? When we're ready we should ping @mafintosh for builds. Maybe we should try to muster some prebuilts for windows as well.

[vweevers]

Build and tests pass on Windows too. I can provide Windows prebuilds when the time comes.

[No9]

Thanks for this @juliangruber - builds and passes on my illumOS based distro
Also good on FreeBSD Current 11

[ralphtheninja]

Build and tests pass on Windows too. I can provide Windows prebuilds when the time comes.

👍

[ralphtheninja]

Builds and tests pass on Debian Jessie.

[juliangruber]

This sounds great!

I would just leave this here and wait for @chjj's tests results, then merge and release. (it's easy to by mistake release something when it's already in master)

By SemVer standard yeah it should be 1.4.7, but by "slightly personal meaningful semver" standard it should be 1.5.0

[mafintosh]

Great job @juliangruber. I think we should leave the PR open for a few days and then merge + release it next week assuming nothing catastrophic appears.

[ralphtheninja]

By SemVer standard yeah it should be 1.4.7, but by "slightly personal meaningful semver" standard it should be 1.5.0

+1 Makes sense.

[rvagg]

This is interesting:

// EXPERIMENTAL: If true, append to existing MANIFEST and log files
// when a database is opened. This can significantly speed up open.
//
// Default: currently false, but may become true later.
bool reuse_logs;

We could enable an undocumented option for this to allow for experimentation. The one problem I see here is that it uses a new NewAppendableFile API in Env which would probably have to be implemented in port-libuv/env_win.cc because even though the documentation says: Users of Env (including the leveldb implementation) must be prepared to deal with an Env that does not support appending. I don't believe it does properly deal with that case!

[rvagg]

PR LGTM except for two nits:

• remove .travis.yml ?
• chmod all files to 644, they are currently 755

[juliangruber]

remove .travis.yml ?
chmod all files to 644, they are currently 755

@rvagg why?

[chjj]

Update: I've been using this branch in practice for a little while now. I've sync'd the entire blockchain with it. Works great.

[rvagg]

remove .travis.yml ?
chmod all files to 644, they are currently 755

@rvagg why?

1. Unnecessary churn, otherwise it's mostly a git rename and not an additional property change
2. These files are not executable and it's incorrect for them to have execute bit set on them except for *.sh

[juliangruber]

@rvagg this might sound stupid but, ...?

also, in current master the deps are already 755

[rvagg]

find deps/leveldb -type f -exec chmod 644 '{}' \; && find deps/leveldb -type d -exec chmod 755 '{}' \;

I'm sure there's some neat umasky way of doing it but that's how I'd do it. Files 644, directories 755.

[juliangruber]

gotcha, should all be addressed now!

[juliangruber]

Final call for @chjj, I'm assuming everything looks good so far?

@ralphtheninja @mafintosh @vweevers how do we orchestrate publishing the prebuilds? Do you want to send yours to me so I can release and upload in one go?

[vweevers]

@juliangruber I can get #309 going, once we reach consensus on:

Tagged commits trigger an upload to GitHub. Which means the AppVeyor job will be the first to create a GH release, whenever someone pushes a tag. Does anyone foresee problems with that? Alternatively, we can manually download artifacts from AppVeyor and attach them to a GH release. WDYT?

[chjj]

I can only speak from my own use here: this works perfectly on every x64 linux machine I've tried it on. Merging sounds good to me.

[ralphtheninja]

@ralphtheninja @mafintosh @vweevers how do we orchestrate publishing the prebuilds? Do you want to send yours to me so I can release and upload in one go?

@juliangruber I'd suggest you sync with @mafintosh so he can push the button on linux and osx. Then we can build for arm and windows and update.

[ralphtheninja]

@juliangruber Can we bump some dependencies before releasing? I'm mainly thinking of the abstract-leveldown fix you made the other day.

[juliangruber]

@ralphtheninja sure! do you want to make a pull request for that?