Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install on arm64 #297

Closed
babolivier opened this issue Jul 22, 2016 · 10 comments
Closed

Can't install on arm64 #297

babolivier opened this issue Jul 22, 2016 · 10 comments

Comments

@babolivier
Copy link

Hi there,

As there seems to be no binary for the arm64 architecture, leveldown won't install on my Pine64 with a simple npm install (so as a dependencie, which is how I want to use it).

Here's some of my Node.js process variables:

[brendan@pine64 data-system]# node
> process.arch
'arm64'
> process.platform
'linux'
> process.versions
{ http_parser: '2.5.2',
  node: '4.4.7',
  v8: '4.5.103.36',
  uv: '1.8.0',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  icu: '56.1',
  modules: '46',
  openssl: '1.0.2h' }
> 

Would it be possible to have binaries built and released for this architecture?

@ralphtheninja
Copy link
Member

@babolivier Since it's linux it should be trivial to build during npm install. If there are no prebuilt binaries it will fallback to compiling leveldb and leveldown .cc files.

@ralphtheninja
Copy link
Member

@babolivier What kind of error message do you get? Please post the results of npm i leveldown --verbose to a gist and share that link.

@babolivier
Copy link
Author

@babolivier
Copy link
Author

Well, sorry for reading the NPM log too quickly, this doesn't seem to happen because of the lack of a binary, but because of this:

../deps/leveldb/leveldb-1.18.0/port/atomic_pointer.h:211:2: error: #error Please implement AtomicPointer for this platform.

@ralphtheninja
Copy link
Member

Ok, so it's having problems while compiling. Unfortunately this seems to be related to the LevelDB c++ lib. You might want to dig around there to see if that has been fixed or not.

@babolivier
Copy link
Author

So I looked around a bit and came accross this issue I didn't see in my first search: #268

As I can guess, support for my architecture will be added in 1.19, which hasn't been released yet. As the last version dates from 2014, I think I'll have better chances at trying to compile leveldb on my platform, so that's what I'm gonna do.

@babolivier
Copy link
Author

No success here (LevelDB having not a single build instruction doesn't help). However, I saw this commit on a fork and wondered if that wouldn't be a nice idea to have it in leveldown, as a quickfix for people using an arm64 architecture while waiting for 1.19?

@No9
Copy link
Contributor

No9 commented Aug 11, 2016

@babolivier So @juliangruber has landed 1.19 #299 (edit wrong link)
If you want to validate this bug against it and feedback we would be delighted to hear from you

@rvagg
Copy link
Member

rvagg commented Aug 23, 2016

Confirmed compile & test are 👍 on ARM64 for the leveldb-1.19 branch.

@babolivier
Copy link
Author

babolivier commented Aug 23, 2016

Hi all, thanks @rvagg for testing, I just didn't have the time to test if everything was OK in the last few days.
If it works on ARM64, then I guess I can close this issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants