Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re #268, #270, updated version of leveldb from google/leveldb master #274

Closed
wants to merge 1 commit into from

Conversation

myf
Copy link

@myf myf commented Apr 15, 2016

  • deps/leveldb/leveldb-1.18-ea992b467b9f3c892ae87267ba908e97d532b1b2/ is
    pulled from the master branch of https://github.com/google/leveldb at
    commit ea992b467b9f3c892ae87267ba908e97d532b1b2
  • added LEVELDB_PLATFORM_UV line in port/port.h
  • modified leveldb.gyp for the new version and renamed
    db/leveldb_main.cc to db/leveldbutil.cc as modified by google

- deps/leveldb/leveldb-1.18-ea992b467b9f3c892ae87267ba908e97d532b1b2/ is
pulled from the master branch of https://github.com/google/leveldb at
commit ea992b467b9f3c892ae87267ba908e97d532b1b2

- added LEVELDB_PLATFORM_UV line in port/port.h

- modified leveldb.gyp for the new version and renamed
db/leveldb_main.cc to db/leveldbutil.cc as modified by google
@myf
Copy link
Author

myf commented Apr 15, 2016

@rvagg google/leveldb v1.18 was published 2 years ago, however there are quite a few improvements since then, including the support for ARMv8 and MIPS support which dated as far back as 2014. It would be great if we upgrade leveldown when leveldb v1.19 comes out but I have no idea how far down the road this would happen.

this pr pulled the latest master of google/leveldb at commit ea992b467b9f3c892ae87267ba908e97d532b1b2, with modified port.h to include port_uv and also modified leveldb.gyp to change a file name from leveldb_main.cc to leveldbutil.cc based on upstream.

The build succeeded and all the tests passed. On my odroid c2 the build was working properly to support ARMv8.

This is an alternative to pull request #270 to support ARMv8 and MIPS. Instead the entire leveldb directory is updated to the latest master. Also since google/leveldb is it's own repository, should we do git submodules instead?

please comment :)

@martinheidegger
Copy link

1.19 has since been published. It might be good to update this PR?

@myf
Copy link
Author

myf commented Oct 10, 2016

@martinheidegger you are right, since 1.19 is merged into the master this PR was intended to fix the same thing before the release of 1.19. will close after i test it on my AARCH64 system :)

@myf
Copy link
Author

myf commented Oct 30, 2016

this is fixed with #299 that pulls leveldb 1.19 which added AARCH64 and MIPS as supported platforms.

@myf myf closed this Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants