fix: remove stale stakes flag - #474
Merged
Merged
Conversation
wadealexc
approved these changes
May 7, 2025
Contributor
Author
|
Note: Storage checker failing due to changing the naming of |
ypatil12
added a commit
that referenced
this pull request
May 7, 2025
**Motivation:** The stale stakes flag is buggy since it doesn't properly get the `quorumUpdateBlockNumber` in the given range. The fix is to add checkpointed storage for the latest quorum update block number. Since we are moving towards a cert-verifier world, it's simpler to remove this feature rather than ship checkpointed storage OR broken code. **Modifications:** Removed `staleStakesForbidden`. **Result:** Cleaner code
ypatil12
added a commit
that referenced
this pull request
May 7, 2025
**Motivation:** Middleware slashing audit fixes from Hexens and Dedaub. **Modifications:** **Medium Sev** - #467 **Low Sev** - #462 - #463 - #468 - #474 - note: this removes stale stakes checks from the `BLSSignatureChecker` **Informational/Docs** - #465 - #466 - #472 **Result:** Audit fixes applied to slashing.
hashmap0x
added a commit
to hashmap0x/eigenlayer-middleware
that referenced
this pull request
Sep 23, 2025
**Motivation:** Middleware slashing audit fixes from Hexens and Dedaub. **Modifications:** **Medium Sev** - Layr-Labs/eigenlayer-middleware#467 **Low Sev** - Layr-Labs/eigenlayer-middleware#462 - Layr-Labs/eigenlayer-middleware#463 - Layr-Labs/eigenlayer-middleware#468 - Layr-Labs/eigenlayer-middleware#474 - note: this removes stale stakes checks from the `BLSSignatureChecker` **Informational/Docs** - Layr-Labs/eigenlayer-middleware#465 - Layr-Labs/eigenlayer-middleware#466 - Layr-Labs/eigenlayer-middleware#472 **Result:** Audit fixes applied to slashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The stale stakes flag is buggy since it doesn't properly get the
quorumUpdateBlockNumberin the given range. The fix is to add checkpointed storage for the latest quorum update block number. Since we are moving towards a cert-verifier world, it's simpler to remove this feature rather than ship checkpointed storage OR broken code.Modifications:
Removed
staleStakesForbidden.Result:
Cleaner code