fix: lookahead period constraint #463
Merged
+48
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakim249CAL
approved these changes
May 1, 2025
ypatil12
added a commit
that referenced
this pull request
May 1, 2025
**Motivation:** An operator is slashable for at least `DEALLOCATION_DELAY`. The check for the lookahead period should be exactly this amount, not less. **Modifications:** Update check for `lookAheadPeriod` to be `<=DEALLOCATION_DELAY`. **Result:** Symmetric checks with #463
ypatil12
added a commit
that referenced
this pull request
May 7, 2025
**Motivation:** Middleware slashing audit fixes from Hexens and Dedaub. **Modifications:** **Medium Sev** - #467 **Low Sev** - #462 - #463 - #468 - #474 - note: this removes stale stakes checks from the `BLSSignatureChecker` **Informational/Docs** - #465 - #466 - #472 **Result:** Audit fixes applied to slashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
StakeRegistryis missing a constraint check for modification of lookahead timeof slashable quorum. This results in the Lookahead period potentially being invalid.
Modifications:
Update
_setLookAheadPeriodto revert if the_lookaheadBlocksis greater than theDEALLOCATION_DELAY. Note that we'll also have to update this check in_createQuorumsince it does a>=check. Operators are slashable for the entire delay, inclusive of the last block.Result:
Proper constraints.