fix: enforce quorum registration on churn #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: #464 was merged to wrong target
Motivation:
It is possible to break the
maxOperatorCount
invariant by doing the following:Let's assume there are two quorums, 1 and 2, with a
maxOperatorCount
of 2.operatorToKick
is registered to the AVS (not the quorum):eigenlayer-middleware/src/SlashingRegistryCoordinator.sol
Lines 405 to 408 in f5adbca
Although this assumes that the
churnApprover
is buggy, we should still be enforcing that you are churning a user if they are registered for the quorum.Modifications:
Require that the
operatorToKick
is registered for the quorum.Result:
Stricter churn guarantees.