fix(renderwindowinteractor): observe KeyPress events on RW container …

[finetjul]

…instead of document

Observing on document produces many false positives. For example, a key press event was for an element but RWI was also processing it.

BREAKING CHANGE: This may break key press event current behavior. Use tabIndex=0 on RW containers to fix it.

fix #1856

Context

Read the description on #1856

Results

This time, it enforces the events are observed on the RW and not on the whole document.
This is important when there are multiple RW in a document.

Changes

• Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

• semantic-release commit messages
• Run npm run reformat to have correctly formatted code

Testing

• This change adds or fixes unit tests
• Tested environment:
  • vtk.js: master
  • OS: Windows
  • Browser: Chrome

[finetjul]

[jourdain]

I defer to Forrest on that one

[floryst]

Since this is a breaking change, let's merge this into the beta branch. I need to merge my "named parameters" branch into beta as well. That way, we have one major change as opposed to two.

[finetjul]

Since this is a breaking change, let's merge this into the beta branch. I need to merge my "named parameters" branch into beta as well. That way, we have one major change as opposed to two.

I'm fine with merging it into the beta branch for now, but can the final merge into master happen soon-ish (e.g. in no more than 1 week)?

[floryst]

Since this is a breaking change, let's merge this into the beta branch. I need to merge my "named parameters" branch into beta as well. That way, we have one major change as opposed to two.

I'm fine with merging it into the beta branch for now, but can the final merge into master happen soon-ish (e.g. in no more than 1 week)?

Sure. I think we're good to go with the existing changes in beta (the volume mapper changes). I'll check to see if it merges cleanly.

[github-actions]

🎉 This PR is included in version 34.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀