Skip to content

Conversation

@Jo-Byr
Copy link
Contributor

@Jo-Byr Jo-Byr commented Nov 7, 2024

Add index.d.ts file for vtkKeyboardCameraManipulator

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul changed the base branch from master to beta November 7, 2024 13:28
@Jo-Byr Jo-Byr force-pushed the typescript-keyboardcameramanipulator branch from b29456f to 4ae995b Compare November 7, 2024 13:46
@floryst
Copy link
Contributor

floryst commented Nov 12, 2024

Overall LGTM! Please run npm run reformat to fix the linter errors in Sources/Interaction/Manipulators/KeyboardCameraManipulator/index.d.ts, and we'll be good to merge.

@Jo-Byr Jo-Byr force-pushed the typescript-keyboardcameramanipulator branch 2 times, most recently from d1024c0 to 9a708e2 Compare November 13, 2024 10:01
Add index.d.ts file for vtkKeyboardCameraManipulator
@Jo-Byr Jo-Byr force-pushed the typescript-keyboardcameramanipulator branch from 9a708e2 to 678489c Compare November 13, 2024 10:09
@finetjul finetjul merged commit e00ae96 into Kitware:beta Nov 13, 2024
3 checks passed
@floryst floryst mentioned this pull request Jun 5, 2025
1 task
floryst added a commit that referenced this pull request Jun 13, 2025
Major changes:
- #3239
- #3224
- #3171
- #3159
- #3158
- #3157
@github-actions
Copy link

🎉 This PR is included in version 34.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants