Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add DFN-4 #1946

Merged
merged 8 commits into from
Jan 5, 2020
Merged

Add DFN-4 #1946

merged 8 commits into from
Jan 5, 2020

Conversation

DanSGiesbrecht
Copy link
Collaborator

@DanSGiesbrecht DanSGiesbrecht commented Oct 29, 2019

Used for Sensirion SHTC3

Made using the footprint generator: pointhi/kicad-footprint-generator#450


image

image


From datasheet:

image

image


  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

Used for Sensiron SHTC3
@DanSGiesbrecht DanSGiesbrecht added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Oct 29, 2019
@poeschlr poeschlr self-assigned this Oct 29, 2019
@poeschlr poeschlr added Question Issue: request for clarification or support, PR: There is an open question (by author or maintainer) and removed Pending reviewer A pull request waiting for a reviewer labels Oct 29, 2019
@DanSGiesbrecht DanSGiesbrecht added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Question Issue: request for clarification or support, PR: There is an open question (by author or maintainer) labels Nov 3, 2019
@DanSGiesbrecht
Copy link
Collaborator Author

DanSGiesbrecht commented Nov 3, 2019

Updates:

  • Closed scripted footprint PR #450
  • Implemented manufacturer-recommended footprint (rather than scripted IPC footprint)
    • Change pad size/position
    • Change solder paste
    • Change courtyard
  • Renamed footprint to: Sensirion_DFN-4-1EP_2x2mm_P1mm_EP0.7x1.6mm
  • Moved footprint to: Sensor_Humidity.pretty
  • Renamed 3D model path: ${KISYS3DMOD}/Sensor_Humidity.3dshapes/Sensirion_DFN-4-1EP_2x2mm_P1mm_EP0.7x1.6mm.wrl
    • The 3D model has not been submitted

image

image

@DanSGiesbrecht
Copy link
Collaborator Author

I've changed the pads to rectangular, to align with #1798

@poeschlr , rather than all footprints square, do you think it makes sense to have the thermal pad be square (as it is 1:1 with the component slug) and the leads be rounded? If so, I'll do that.

@poeschlr
Copy link
Collaborator

poeschlr commented Nov 7, 2019

In the fixes for #1798 we decided to keep even the center pad with rounded edges but chose to use the same radius as for the normal pads. (As the drawings in a lot of datasheets look like this is the case)

I leave it up to you what direction you go.

@poeschlr
Copy link
Collaborator

poeschlr commented Nov 9, 2019

I would say the courtyard should be relative to the copper pad not the paste pad.

Screenshot from 2019-11-09 16-15-36

@poeschlr poeschlr added Pending changes and removed Ready for review Use this to mark pull requests that are updated but you could not review instantly labels Nov 9, 2019
Courtyard is now relative to copper pad,
not to solder paste (on x-dimension).
@DanSGiesbrecht
Copy link
Collaborator Author

DanSGiesbrecht commented Nov 9, 2019

Thanks @poeschlr - made the suggested changes:

  • Pads have been reverted to round-rect (I prefer this)
  • X-axis courtyard is now relative to the copper, rather than solder paste

As an aside: I know I've asked this before, but how do you generate the dimensioned drawings? They're very handy!

@DanSGiesbrecht DanSGiesbrecht added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Nov 9, 2019
@chschlue
Copy link
Contributor

chschlue commented Nov 9, 2019

https://forum.kicad.info/t/how-to-check-footprint-correctness/9279

@poeschlr
Copy link
Collaborator

The drawing shown here is made slightly differently to how i wrote in the tutorial as the drawing dimensions workbench no longer works with my freecad version.
I used techdraw to export a dxf and added the dimensions with librecad.

@DanSGiesbrecht
Copy link
Collaborator Author

@poeschlr thanks for the tip!

This should be ready to merge.

@chschlue
Copy link
Contributor

@poeschlr Out of curiosity, what's wrong with TechDraw dimensions?

@poeschlr
Copy link
Collaborator

poeschlr commented Nov 13, 2019

@chshlue Techdraw in freecad 0.18 has no way to reference a center point of a line. It also has a very bad user interface for adding dimensions (i need to select two points, click the add dimension tool, place the dimension, repeat.)

And it is generally quite unstable. For example changing scaling, line widths, ... all only works sometimes. Luckily with dxf export i do not care about these as librecad does everything for me.
Maybe the 0.19 techdraw workbench will be better especially once 0.19 is a true release. (right now it is a dev snapshot) Sadly the 0.19 version for fedora has some bugs with techdraw (probably some dependency problem) and also crashes quite often.

@chschlue
Copy link
Contributor

I see.
Much of that has gotten a lot better with 0.19. First and foremost the center point issue which was a complete show-stopper.
Have you tried the 0.19pre AppImage? It at least brings its dependencies with it.

@DanSGiesbrecht
Copy link
Collaborator Author

@poeschlr can this be merged?

@poeschlr
Copy link
Collaborator

poeschlr commented Jan 5, 2020

Thanks

@poeschlr poeschlr merged commit b1804a2 into KiCad:master Jan 5, 2020
@poeschlr poeschlr removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Jan 5, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Jan 5, 2020
@DanSGiesbrecht DanSGiesbrecht deleted the dev/sht branch January 6, 2020 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants